From c05df68080e26acf858307fa4871c3af0b565e6b Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Tue, 25 Jan 2022 13:22:39 -0800 Subject: [PATCH 1/3] Show unrendered cells as gray when scrolling/not yet virtualized --- src/components/datagrid/_data_grid.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/datagrid/_data_grid.scss b/src/components/datagrid/_data_grid.scss index a04401f0840..ec8cdffd0e2 100644 --- a/src/components/datagrid/_data_grid.scss +++ b/src/components/datagrid/_data_grid.scss @@ -30,7 +30,7 @@ width: 100%; overflow: hidden; z-index: 2; // Sits above the pagination below it, but below the controls above it - background: $euiColorEmptyShade; + background: $euiPageBackgroundColor; font-feature-settings: 'tnum' 1; // Tabular numbers } From cc340654d4f06677c2243964f0190b246f7d0001 Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Tue, 25 Jan 2022 13:23:13 -0800 Subject: [PATCH 2/3] Misc cleanup - move toolbar related css to toolbar scss file --- src/components/datagrid/_data_grid.scss | 8 -------- src/components/datagrid/controls/_data_grid_toolbar.scss | 7 +++++++ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/components/datagrid/_data_grid.scss b/src/components/datagrid/_data_grid.scss index ec8cdffd0e2..ba25565af83 100644 --- a/src/components/datagrid/_data_grid.scss +++ b/src/components/datagrid/_data_grid.scss @@ -49,14 +49,6 @@ } } - -.euiDataGrid__controlScroll { - @include euiYScrollWithShadows; - max-height: $euiDataGridPopoverMaxHeight; - padding: $euiSizeS; - margin: -$euiSizeS; // Offset against the panel to make the scrollbar flush scrollbars -} - .euiDataGrid__focusWrap { height: 100%; } diff --git a/src/components/datagrid/controls/_data_grid_toolbar.scss b/src/components/datagrid/controls/_data_grid_toolbar.scss index c9144561a4f..5d14870554f 100644 --- a/src/components/datagrid/controls/_data_grid_toolbar.scss +++ b/src/components/datagrid/controls/_data_grid_toolbar.scss @@ -59,3 +59,10 @@ transition: none !important; margin-top: -$euiSizeS; } + +.euiDataGrid__controlScroll { + @include euiYScrollWithShadows; + max-height: $euiDataGridPopoverMaxHeight; + padding: $euiSizeS; + margin: -$euiSizeS; // Offset against the panel to make the scrollbar flush scrollbars +} From 01256b2e110fbc590963dde9246a8a10776c1559 Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Tue, 25 Jan 2022 15:03:00 -0800 Subject: [PATCH 3/3] Add changelog entry --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4f3933e2d6c..b105dec44f4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ ## [`main`](https://github.com/elastic/eui/tree/main) -No public interface changes since `46.1.0`. +- Updated `EuiDataGrid`'s body to a light gray background, which primarily shows when scrolling through virtualized content ([#5562](https://github.com/elastic/eui/pull/5562)) ## [`46.1.0`](https://github.com/elastic/eui/tree/v46.1.0)