Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[metricbeat] Follow migration from kube-state-metrics charts out of stable repo #733

Closed
jmlrt opened this issue Jul 16, 2020 · 16 comments
Closed
Labels
enhancement New feature or request metricbeat

Comments

@jmlrt
Copy link
Member

jmlrt commented Jul 16, 2020

Metricbeat chart currently use kube-state-metrics chart as subchart to get metrics from K8S.

As Stable repo will be deprecated in November 2020 (see Deprecation timeline), kube-state-metrics chart will need to migrate to another repository.

This work seem to be tracked in kubernetes/kube-state-metrics#1153.

When the migration will be over, Metricbeat chart will need to be updated to get kube-state-metrics subchart from its new home.

@jmlrt jmlrt added the enhancement New feature or request label Jul 16, 2020
@jmlrt
Copy link
Member Author

jmlrt commented Oct 30, 2020

While waiting for kube-state-metrics chart migration to a new GitHub repository, We need to update Metricbeat chart requirements to retrieve the subchart from the new stable Helm repos url => #882

@botelastic
Copy link

botelastic bot commented Jan 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@jmlrt
Copy link
Member Author

jmlrt commented Jan 29, 2021

still valid

@botelastic botelastic bot removed the triage/stale label Jan 29, 2021
@jmlrt
Copy link
Member Author

jmlrt commented Feb 3, 2021

For later reference, kube-state-metrics chart is now hosted at https://github.com/kubernetes/kube-state-metrics/tree/master/charts/kube-state-metrics

@christophercutajar
Copy link

While deploying an ECK cluster using terraform, I've deployed kube-state-metrics v2.13.0 using the official chart from https://kubernetes.github.io/kube-state-metrics. One breaking change I've encountered in the official helm chart is in below line:

value: "$({{ .Release.Name | replace "-" "_" | upper }}_KUBE_STATE_METRICS_SERVICE_HOST):$({{ .Release.Name | replace "-" "_" | upper }}_KUBE_STATE_METRICS_SERVICE_PORT_HTTP)"

As a solution, I've changed the aforementioned line to read as follows: "$(KUBE_STATE_METRICS_SERVICE_HOST):$(KUBE_STATE_METRICS_SERVICE_PORT_HTTP)"

Metricbeat deployment was deployment successfully with this change.

Happy to help in fully testing and performing the necessary changes!

@botelastic
Copy link

botelastic bot commented Jun 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@jmlrt
Copy link
Member Author

jmlrt commented Jun 23, 2021

still valid

@botelastic botelastic bot removed the triage/stale label Jun 23, 2021
@botelastic
Copy link

botelastic bot commented Sep 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@jmlrt
Copy link
Member Author

jmlrt commented Sep 21, 2021

still valid

@botelastic botelastic bot removed the triage/stale label Sep 21, 2021
@christophercutajar
Copy link

@jmlrt let me know how can I help in achieving this!

@jmlrt
Copy link
Member Author

jmlrt commented Sep 27, 2021

Hi @christophercutajar,
Sorry I totally missed your previous comment.
Thanks for your help!

I didn't try the new kube-state-metrics yet. It seems you did it.

Do you think you could create a PR?

Also, the most important things to check is to ensure that metrics are reported correctly with this new version and to check if metricbeat upgrade tests are successful (https://devops-ci.elastic.co/view/Helm%20Charts/job/elastic+helm-charts+pull-request+integration-metricbeat/1067/).

@jmlrt
Copy link
Member Author

jmlrt commented Sep 27, 2021

For the records, the new chart code is here:

@christophercutajar
Copy link

We've been using kube-state-metrics v2.13.0 it productions since March - https://github.com/elastic/seceng/issues/2028 and didn't had any issues but we need to perform testing with the latest version.

I'll work on it in the next couple of days and will create the necessary PR.

@botelastic
Copy link

botelastic bot commented Dec 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@christophercutajar
Copy link

Haven't been able to dedicate time to this. Will plan for this during January

@botelastic botelastic bot removed the triage/stale label Dec 28, 2021
@jmlrt
Copy link
Member Author

jmlrt commented Mar 8, 2022

This was done in #1524.

@jmlrt jmlrt closed this as completed Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request metricbeat
Projects
None yet
Development

No branches or pull requests

2 participants