From 26b22746b7794018f44dc95fa6fbfa57ba38e41e Mon Sep 17 00:00:00 2001 From: Nathan Reese Date: Tue, 10 Jan 2023 16:08:22 -0500 Subject: [PATCH] [drilldown] fix Darktheme is missing from add drilldowns panel (#147270) Fixes https://github.com/elastic/kibana/issues/147147 Replaces https://github.com/elastic/kibana/pull/147151. Thanks for the tip @Dosant PR passes theme$ to toMountPoint Screen Shot 2022-12-06 at 4 54 49 PM Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> --- .../flyout_create_drilldown/flyout_create_drilldown.test.tsx | 3 +++ .../flyout_create_drilldown/flyout_create_drilldown.tsx | 3 ++- .../flyout_edit_drilldown/flyout_edit_drilldown.test.tsx | 3 +++ .../actions/flyout_edit_drilldown/flyout_edit_drilldown.tsx | 3 ++- 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.test.tsx b/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.test.tsx index 295bf8968bd5d9..165f80cdf51e88 100644 --- a/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.test.tsx +++ b/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.test.tsx @@ -26,6 +26,9 @@ const actionParams: OpenFlyoutAddDrilldownParams = { application: { currentAppId$: new Subject(), }, + theme: { + theme$: new Subject(), + }, } as any, plugins: { uiActionsEnhanced, diff --git a/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.tsx b/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.tsx index 582133890a4bc3..5307d2aaa77fe1 100644 --- a/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.tsx +++ b/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.tsx @@ -106,7 +106,8 @@ export class FlyoutCreateDrilldownAction implements Action { placeContext={{ embeddable }} templates={templates} onClose={close} - /> + />, + { theme$: core.theme.theme$ } ), { ownFocus: true, diff --git a/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/flyout_edit_drilldown.test.tsx b/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/flyout_edit_drilldown.test.tsx index b0aef4d4eb7199..fe0d6df5972c40 100644 --- a/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/flyout_edit_drilldown.test.tsx +++ b/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/flyout_edit_drilldown.test.tsx @@ -36,6 +36,9 @@ const actionParams: FlyoutEditDrilldownParams = { application: { currentAppId$: new Subject(), }, + theme: { + theme$: new Subject(), + }, } as any, plugins: { uiActionsEnhanced: uiActions, diff --git a/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/flyout_edit_drilldown.tsx b/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/flyout_edit_drilldown.tsx index d6c21a83f23122..a97cce9ecf75cc 100644 --- a/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/flyout_edit_drilldown.tsx +++ b/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/flyout_edit_drilldown.tsx @@ -80,7 +80,8 @@ export class FlyoutEditDrilldownAction implements Action { placeContext={{ embeddable }} templates={templates} onClose={close} - /> + />, + { theme$: core.theme.theme$ } ), { ownFocus: true,