From 3166031ee06734cb47ed0e36bf8a7cbb5490f23f Mon Sep 17 00:00:00 2001 From: Brian Seeders Date: Tue, 7 Jan 2020 16:24:15 -0500 Subject: [PATCH] ES snapshot changes required for 6.8 --- packages/kbn-es/src/artifact.js | 6 +++--- packages/kbn-es/src/artifact.test.js | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/kbn-es/src/artifact.js b/packages/kbn-es/src/artifact.js index d9f6c93779cbdd..8aab8f2b5f88c4 100644 --- a/packages/kbn-es/src/artifact.js +++ b/packages/kbn-es/src/artifact.js @@ -117,17 +117,17 @@ async function getArtifactSpecForSnapshot(urlVersion, license, log) { const manifest = JSON.parse(json); - const platform = process.platform === 'win32' ? 'windows' : process.platform; + const ext = process.platform === 'win32' ? 'zip' : 'tar.gz'; const archive = manifest.archives.find( archive => archive.version === desiredVersion && - archive.platform === platform && + archive.filename.endsWith(ext) && archive.license === desiredLicense ); if (!archive) { throw createCliError( - `Snapshots for ${desiredVersion} are available, but couldn't find an artifact in the manifest for [${desiredVersion}, ${desiredLicense}, ${platform}]` + `Snapshots for ${desiredVersion} are available, but couldn't find an artifact in the manifest for [${desiredVersion}, ${desiredLicense}, ${ext}]` ); } diff --git a/packages/kbn-es/src/artifact.test.js b/packages/kbn-es/src/artifact.test.js index 985b65c7475634..f60576f5b6cadb 100644 --- a/packages/kbn-es/src/artifact.test.js +++ b/packages/kbn-es/src/artifact.test.js @@ -27,7 +27,7 @@ import { Artifact } from './artifact'; const log = new ToolingLog(); let MOCKS; -const PLATFORM = process.platform === 'win32' ? 'windows' : process.platform; +const EXT = process.platform === 'win32' ? 'zip' : 'tar.gz'; const MOCK_VERSION = 'test-version'; const MOCK_URL = 'http://127.0.0.1:12345'; const MOCK_FILENAME = 'test-filename'; @@ -43,8 +43,8 @@ const createArchive = (params = {}) => { license: 'default', version: MOCK_VERSION, url: MOCK_URL + `/${license}`, - platform: PLATFORM, - filename: MOCK_FILENAME + `.${license}`, + platform: 'no-jdk', + filename: `${MOCK_FILENAME}.${license}.${EXT}`, ...params, }; }; @@ -94,7 +94,7 @@ const artifactTest = (requestedLicense, expectedLicense, fetchTimesCalled = 1) = expect(artifact.getUrl()).toEqual(MOCK_URL + `/${expectedLicense}`); expect(artifact.getChecksumUrl()).toEqual(MOCK_URL + `/${expectedLicense}.sha512`); expect(artifact.getChecksumType()).toEqual('sha512'); - expect(artifact.getFilename()).toEqual(MOCK_FILENAME + `.${expectedLicense}`); + expect(artifact.getFilename()).toEqual(`${MOCK_FILENAME}.${expectedLicense}.${EXT}`); }; };