diff --git a/x-pack/plugins/security_solution/common/experimental_features.ts b/x-pack/plugins/security_solution/common/experimental_features.ts index 02e381fa7cb9e4..b596ea6b554319 100644 --- a/x-pack/plugins/security_solution/common/experimental_features.ts +++ b/x-pack/plugins/security_solution/common/experimental_features.ts @@ -114,9 +114,9 @@ export const allowedExperimentalValues = Object.freeze({ securitySolutionNotesEnabled: false, /** - * Enables entity and alert previews + * Disables entity and alert previews */ - entityAlertPreviewEnabled: false, + entityAlertPreviewDisabled: false, /** * Enables the Assistant Model Evaluation advanced setting and API endpoint, introduced in `8.11.0`. diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs.test.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs.test.tsx index d6a247f6558a78..6995656db31a5c 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs.test.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs.test.tsx @@ -130,7 +130,7 @@ describe('RiskInputsTab', () => { }); it('it renders alert preview button when feature flag is enable', () => { - mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); mockUseRiskScore.mockReturnValue({ loading: false, error: false, @@ -152,7 +152,7 @@ describe('RiskInputsTab', () => { }); it('it does not render alert preview button when feature flag is disable', () => { - mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); mockUseRiskScore.mockReturnValue({ loading: false, error: false, diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx index f4514c6bf8f2be..7f59ac7efbf423 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx @@ -100,7 +100,7 @@ export const RiskInputsTab = ({ entityType, entityName, scopeId }: RiskInputsTab }), [] ); - const isPreviewEnabled = useIsExperimentalFeatureEnabled('entityAlertPreviewEnabled'); + const isPreviewEnabled = !useIsExperimentalFeatureEnabled('entityAlertPreviewDisabled'); const inputColumns: Array> = useMemo( () => [ diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/correlations_details_alerts_table.test.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/correlations_details_alerts_table.test.tsx index ebea2481ab8295..f9391fe8fec063 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/correlations_details_alerts_table.test.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/correlations_details_alerts_table.test.tsx @@ -49,7 +49,7 @@ const renderCorrelationsTable = (panelContext: DocumentDetailsContext) => describe('CorrelationsDetailsAlertsTable', () => { beforeEach(() => { jest.mocked(useExpandableFlyoutApi).mockReturnValue(mockFlyoutApi); - mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); jest.mocked(usePaginatedAlerts).mockReturnValue({ setPagination: jest.fn(), setSorting: jest.fn(), @@ -106,7 +106,7 @@ describe('CorrelationsDetailsAlertsTable', () => { }); it('renders open preview button when feature flag is on', () => { - mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); const { getByTestId, getAllByTestId } = renderCorrelationsTable({ ...mockContextValue, isPreviewMode: true, diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/correlations_details_alerts_table.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/correlations_details_alerts_table.tsx index cf55e02d9d478e..178adabb80700f 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/correlations_details_alerts_table.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/correlations_details_alerts_table.tsx @@ -80,7 +80,7 @@ export const CorrelationsDetailsAlertsTable: FC>) => { diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/host_details.test.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/host_details.test.tsx index 49a10875c67a09..213bfbbecaa253 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/host_details.test.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/host_details.test.tsx @@ -158,7 +158,7 @@ describe('', () => { mockUseHostDetails.mockReturnValue(mockHostDetailsResponse); mockUseRiskScore.mockReturnValue(mockRiskScoreResponse); mockUseHostsRelatedUsers.mockReturnValue(mockRelatedUsersResponse); - mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); }); it('should render host details correctly', () => { @@ -168,7 +168,7 @@ describe('', () => { }); it('should render host name as clicable link when feature flag is true', () => { - mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); const { getByTestId } = renderHostDetails(mockContextValue); expect(getByTestId(HOST_DETAILS_LINK_TEST_ID)).toBeInTheDocument(); @@ -272,7 +272,7 @@ describe('', () => { }); it('should render user name as clicable link when feature flag is true', () => { - mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); const { getAllByTestId } = renderHostDetails(mockContextValue); expect(getAllByTestId(HOST_DETAILS_RELATED_USERS_LINK_TEST_ID).length).toBe(1); diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/host_details.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/host_details.tsx index 083c9b5beaef1c..594409c82f880c 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/host_details.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/host_details.tsx @@ -97,7 +97,7 @@ export const HostDetails: React.FC = ({ hostName, timestamp, s const isEntityAnalyticsAuthorized = isPlatinumOrTrialLicense && hasEntityAnalyticsCapability; const { openPreviewPanel } = useExpandableFlyoutApi(); - const isPreviewEnabled = useIsExperimentalFeatureEnabled('entityAlertPreviewEnabled'); + const isPreviewEnabled = !useIsExperimentalFeatureEnabled('entityAlertPreviewDisabled'); const narrowDateRange = useCallback( (score, interval) => { diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/prevalence_details.test.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/prevalence_details.test.tsx index 43c5dc2cbe3a51..5b7da67186e34f 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/prevalence_details.test.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/prevalence_details.test.tsx @@ -130,7 +130,7 @@ describe('PrevalenceDetails', () => { jest.clearAllMocks(); licenseServiceMock.isPlatinumPlus.mockReturnValue(true); jest.mocked(useExpandableFlyoutApi).mockReturnValue(mockFlyoutApi); - mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); }); it('should render the table with all data if license is platinum', () => { @@ -159,7 +159,7 @@ describe('PrevalenceDetails', () => { }); it('should render host and user name as clickable link if feature flag is true', () => { - mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); (usePrevalence as jest.Mock).mockReturnValue(mockPrevelanceReturnValue); const { getByTestId } = renderPrevalenceDetails(); diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/prevalence_details.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/prevalence_details.tsx index 18c48379d1df11..e3134591d6c9be 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/prevalence_details.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/prevalence_details.tsx @@ -352,7 +352,7 @@ export const PrevalenceDetails: React.FC = () => { const { telemetry } = useKibana().services; const isPlatinumPlus = useLicense().isPlatinumPlus(); - const isPreviewEnabled = useIsExperimentalFeatureEnabled('entityAlertPreviewEnabled'); + const isPreviewEnabled = !useIsExperimentalFeatureEnabled('entityAlertPreviewDisabled'); // these two are used by the usePrevalence hook to fetch the data const [start, setStart] = useState(DEFAULT_FROM); diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/user_details.test.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/user_details.test.tsx index b00bb091d070fc..02764d25b975e9 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/user_details.test.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/user_details.test.tsx @@ -155,7 +155,7 @@ describe('', () => { mockUseObservedUserDetails.mockReturnValue(mockUserDetailsResponse); mockUseRiskScore.mockReturnValue(mockRiskScoreResponse); mockUseUsersRelatedHosts.mockReturnValue(mockRelatedHostsResponse); - mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); }); it('should render user details correctly', () => { @@ -165,7 +165,7 @@ describe('', () => { }); it('should render user name as clicable link when feature flag is true', () => { - mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); const { getByTestId } = renderUserDetails(mockContextValue); expect(getByTestId(USER_DETAILS_LINK_TEST_ID)).toBeInTheDocument(); @@ -254,7 +254,7 @@ describe('', () => { }); it('should render host name as clicable link when feature flag is true', () => { - mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); const { getAllByTestId } = renderUserDetails(mockContextValue); expect(getAllByTestId(USER_DETAILS_RELATED_HOSTS_LINK_TEST_ID).length).toBe(1); diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/user_details.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/user_details.tsx index eada1fe7909b04..a3d335b913148a 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/user_details.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/user_details.tsx @@ -98,7 +98,7 @@ export const UserDetails: React.FC = ({ userName, timestamp, s const isEntityAnalyticsAuthorized = isPlatinumOrTrialLicense && hasEntityAnalyticsCapability; const { openPreviewPanel } = useExpandableFlyoutApi(); - const isPreviewEnabled = useIsExperimentalFeatureEnabled('entityAlertPreviewEnabled'); + const isPreviewEnabled = !useIsExperimentalFeatureEnabled('entityAlertPreviewDisabled'); const narrowDateRange = useCallback( (score, interval) => { diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/highlighted_fields_cell.test.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/highlighted_fields_cell.test.tsx index dfa62ecf33c222..3ebb00c3b7c75c 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/highlighted_fields_cell.test.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/highlighted_fields_cell.test.tsx @@ -58,7 +58,7 @@ const renderHighlightedFieldsCell = (values: string[], field: string) => describe('', () => { beforeAll(() => { jest.mocked(useExpandableFlyoutApi).mockReturnValue(mockFlyoutApi); - mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); }); it('should render a basic cell', () => { @@ -99,7 +99,7 @@ describe('', () => { }); it('should open host preview when click on host when feature flag is on', () => { - mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); const { getByTestId } = renderHighlightedFieldsCell(['test host'], 'host.name'); getByTestId(HIGHLIGHTED_FIELDS_LINKED_CELL_TEST_ID).click(); @@ -114,7 +114,7 @@ describe('', () => { }); it('should open user preview when click on user when feature flag is on', () => { - mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); const { getByTestId } = renderHighlightedFieldsCell(['test user'], 'user.name'); getByTestId(HIGHLIGHTED_FIELDS_LINKED_CELL_TEST_ID).click(); diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/highlighted_fields_cell.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/highlighted_fields_cell.tsx index 5590543dc59505..8ff457ba6ee223 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/highlighted_fields_cell.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/highlighted_fields_cell.tsx @@ -52,7 +52,7 @@ interface LinkFieldCellProps { const LinkFieldCell: VFC = ({ field, value }) => { const { scopeId, eventId, indexName } = useDocumentDetailsContext(); const { openLeftPanel, openPreviewPanel } = useExpandableFlyoutApi(); - const isPreviewEnabled = useIsExperimentalFeatureEnabled('entityAlertPreviewEnabled'); + const isPreviewEnabled = !useIsExperimentalFeatureEnabled('entityAlertPreviewDisabled'); const { telemetry } = useKibana().services; const goToInsightsEntities = useCallback(() => { diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/host_entity_overview.test.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/host_entity_overview.test.tsx index 0fcdf4b380d8ef..f554f578c86cd7 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/host_entity_overview.test.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/host_entity_overview.test.tsx @@ -87,7 +87,7 @@ const renderHostEntityContent = () => describe('', () => { beforeAll(() => { jest.mocked(useExpandableFlyoutApi).mockReturnValue(mockFlyoutApi); - mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); }); describe('license is valid', () => { @@ -184,7 +184,7 @@ describe('', () => { it('should open host preview when clicking on title when feature flag is on', () => { mockUseHostDetails.mockReturnValue([false, { hostDetails: hostData }]); mockUseRiskScore.mockReturnValue({ data: riskLevel, isAuthorized: true }); - mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); const { getByTestId } = renderHostEntityContent(); diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/host_entity_overview.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/host_entity_overview.tsx index ee22425bf5ed58..815bbcf93e02aa 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/host_entity_overview.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/host_entity_overview.tsx @@ -82,7 +82,7 @@ export const HostEntityOverview: React.FC = ({ hostName const { openLeftPanel, openPreviewPanel } = useExpandableFlyoutApi(); const { telemetry } = useKibana().services; - const isPreviewEnabled = useIsExperimentalFeatureEnabled('entityAlertPreviewEnabled'); + const isPreviewEnabled = !useIsExperimentalFeatureEnabled('entityAlertPreviewDisabled'); const goToEntitiesTab = useCallback(() => { openLeftPanel({ diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/user_entity_overview.test.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/user_entity_overview.test.tsx index fd703e401b6d4c..d1d9651b9d5f17 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/user_entity_overview.test.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/user_entity_overview.test.tsx @@ -92,7 +92,7 @@ const renderUserEntityOverview = () => describe('', () => { beforeAll(() => { jest.mocked(useExpandableFlyoutApi).mockReturnValue(mockFlyoutApi); - mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); }); describe('license is valid', () => { @@ -198,7 +198,7 @@ describe('', () => { it('should open user preview if feature flag is true', () => { mockUseUserDetails.mockReturnValue([false, { userDetails: userData }]); mockUseRiskScore.mockReturnValue({ data: riskLevel, isAuthorized: true }); - mockUseIsExperimentalFeatureEnabled.mockReturnValue(true); + mockUseIsExperimentalFeatureEnabled.mockReturnValue(false); const { getByTestId } = render( diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/user_entity_overview.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/user_entity_overview.tsx index 62700fa6952b4a..c5f8bd2c9319e4 100644 --- a/x-pack/plugins/security_solution/public/flyout/document_details/right/components/user_entity_overview.tsx +++ b/x-pack/plugins/security_solution/public/flyout/document_details/right/components/user_entity_overview.tsx @@ -82,7 +82,7 @@ export const UserEntityOverview: React.FC = ({ userName const { openLeftPanel, openPreviewPanel } = useExpandableFlyoutApi(); const { telemetry } = useKibana().services; - const isPreviewEnabled = useIsExperimentalFeatureEnabled('entityAlertPreviewEnabled'); + const isPreviewEnabled = !useIsExperimentalFeatureEnabled('entityAlertPreviewDisabled'); const goToEntitiesTab = useCallback(() => { openLeftPanel({ diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_left_panel_entities_tab.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_left_panel_entities_tab.cy.ts index 3f86c2859751bc..00286398b0fb64 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_left_panel_entities_tab.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_left_panel_entities_tab.cy.ts @@ -9,11 +9,9 @@ import { DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_ENTITIES_BUTTON, DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_HOST_DETAILS, DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_HOST_DETAILS_RIGHT_SECTION, - DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_HOST_DETAILS_TITLE, DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_HOST_DETAILS_LINK, DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_USER_DETAILS, DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_USER_DETAILS_RIGHT_SECTION, - DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_USER_DETAILS_TITLE, DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_USER_DETAILS_LINK, } from '../../../../screens/expandable_flyout/alert_details_left_panel_entities_tab'; import { @@ -68,24 +66,12 @@ describe( .should('have.text', 'Entities') .and('have.class', 'euiButtonGroupButton-isSelected'); - // github.com/elastic/security-team/issues/9933 - // Comment out when feature flag 'entityAlertPreviewEnabled' is enabled - cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_USER_DETAILS_TITLE).should( - 'contain.text', - 'test' - ); cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_USER_DETAILS_RIGHT_SECTION).should( 'contain.text', 'Related hosts: 0' ); cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_USER_DETAILS).should('exist'); - // github.com/elastic/security-team/issues/9933 - // Comment out when feature flag 'entityAlertPreviewEnabled' is enabled - cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_HOST_DETAILS_TITLE).should( - 'contain.text', - 'siem-kibana' - ); cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_HOST_DETAILS_RIGHT_SECTION).should( 'contain.text', 'Related users: 0' @@ -93,9 +79,7 @@ describe( cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_HOST_DETAILS).should('exist'); }); - // github.com/elastic/security-team/issues/9933 - // Enable when feature flag 'entityAlertPreviewEnabled' is enabled - it.skip('should open host preview when click on host details title', () => { + it('should open host preview when click on host details title', () => { cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_HOST_DETAILS_LINK).should( 'contain.text', 'siem-kibana' @@ -115,9 +99,7 @@ describe( cy.get(HOST_PREVIEW_PANEL_FOOTER).should('not.exist'); }); - // github.com/elastic/security-team/issues/9933 - // Enable when feature flag 'entityAlertPreviewEnabled' is enabled - it.skip('should open user preview when click on user details title', () => { + it('should open user preview when click on user details title', () => { cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_USER_DETAILS_LINK).should('contain.text', 'test'); cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_USER_DETAILS_LINK).click(); diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_left_panel_prevalence_tab.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_left_panel_prevalence_tab.cy.ts index 813c4f2c1229a7..354f0e01647718 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_left_panel_prevalence_tab.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_left_panel_prevalence_tab.cy.ts @@ -100,9 +100,7 @@ describe( ); }); - // github.com/elastic/security-team/issues/9933 - // Enable when feature flag 'entityAlertPreviewEnabled' is enabled - it.skip('should open host preview when click on host details title', () => { + it('should open host preview when click on host details title', () => { cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_PREVALENCE_TABLE_HOST_CELL).click(); cy.get(PREVIEW_SECTION).should('exist'); @@ -118,9 +116,7 @@ describe( cy.get(HOST_PREVIEW_PANEL_FOOTER).should('not.exist'); }); - // github.com/elastic/security-team/issues/9933 - // Enable when feature flag 'entityAlertPreviewEnabled' is enabled - it.skip('should open user preview when click on user details title', () => { + it('should open user preview when click on user details title', () => { cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_PREVALENCE_TABLE_USER_CELL).click(); cy.get(PREVIEW_SECTION).should('exist'); diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_preview_panel.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_preview_panel.cy.ts index c000b06ff1016a..e40ffae02ef9ba 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_preview_panel.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_preview_panel.cy.ts @@ -50,9 +50,7 @@ import { openTableTab, } from '../../../../tasks/expandable_flyout/alert_details_right_panel'; -// github.com/elastic/security-team/issues/9933 -// Enable when feature flag 'entityAlertPreviewEnabled' is enabled -describe.skip( +describe( 'Opening alert previews from alert details flyout', { tags: ['@ess', '@serverless'] }, () => { diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_right_panel_overview_tab.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_right_panel_overview_tab.cy.ts index b9c44b4ad5f722..d243e3f51cd2ec 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_right_panel_overview_tab.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/alert_details_right_panel_overview_tab.cy.ts @@ -6,10 +6,7 @@ */ import { deleteAlertsAndRules } from '../../../../tasks/api_calls/common'; -import { - closeFlyout, - collapseDocumentDetailsExpandableFlyoutLeftSection, -} from '../../../../tasks/expandable_flyout/alert_details_right_panel'; +import { closeFlyout } from '../../../../tasks/expandable_flyout/alert_details_right_panel'; import { createNewCaseFromExpandableFlyout, expandAlertAtIndexExpandableFlyout, @@ -65,11 +62,7 @@ import { createRule } from '../../../../tasks/api_calls/rules'; import { getNewRule } from '../../../../objects/rule'; import { ALERTS_URL } from '../../../../urls/navigation'; import { waitForAlertsToPopulate } from '../../../../tasks/create_new_rule'; -import { - DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_ENTITIES_BUTTON, - DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_HOST_DETAILS, - DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_USER_DETAILS, -} from '../../../../screens/expandable_flyout/alert_details_left_panel_entities_tab'; +import { DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_ENTITIES_BUTTON } from '../../../../screens/expandable_flyout/alert_details_left_panel_entities_tab'; import { DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB, DOCUMENT_DETAILS_FLYOUT_INVESTIGATION_TAB, @@ -238,29 +231,7 @@ describe( ); }); - // github.com/elastic/security-team/issues/9933 - // Skip when feature flag 'entityAlertPreviewEnabled' is enabled - it('should open entities details when clicking host name and user name', () => { - const hostNameCell = - DOCUMENT_DETAILS_FLYOUT_OVERVIEW_TAB_HIGHLIGHTED_FIELDS_TABLE_VALUE_CELL('siem-kibana'); - cy.get(hostNameCell).and('have.text', 'siem-kibana'); - - cy.get(hostNameCell).click(); - cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_HOST_DETAILS).should('exist'); - - collapseDocumentDetailsExpandableFlyoutLeftSection(); - - const userNameCell = - DOCUMENT_DETAILS_FLYOUT_OVERVIEW_TAB_HIGHLIGHTED_FIELDS_TABLE_VALUE_CELL('test'); - cy.get(userNameCell).should('have.text', 'test'); - - cy.get(userNameCell).click(); - cy.get(DOCUMENT_DETAILS_FLYOUT_INSIGHTS_TAB_USER_DETAILS).should('exist'); - }); - - // github.com/elastic/security-team/issues/9933 - // Enable when feature flag 'entityAlertPreviewEnabled' is enabled - it.skip('should open host preview when host name is clicked', () => { + it('should open host preview when host name is clicked', () => { toggleOverviewTabAboutSection(); cy.log('should open host preview when clicked on host name'); @@ -282,9 +253,7 @@ describe( cy.get(HOST_PREVIEW_PANEL_FOOTER).should('not.exist'); }); - // github.com/elastic/security-team/issues/9933 - // Enable when feature flag 'entityAlertPreviewEnabled' is enabled - it.skip('should open user preview when user name is clicked', () => { + it('should open user preview when user name is clicked', () => { toggleOverviewTabAboutSection(); const userNameCell = @@ -328,9 +297,7 @@ describe( .and('have.class', 'euiButtonGroupButton-isSelected'); }); - // github.com/elastic/security-team/issues/9933 - // Enable when feature flag 'entityAlertPreviewEnabled' is enabled - it.skip('open host preview when host name is clicked', () => { + it('open host preview when host name is clicked', () => { toggleOverviewTabAboutSection(); toggleOverviewTabInvestigationSection(); toggleOverviewTabInsightsSection(); @@ -352,9 +319,7 @@ describe( cy.get(HOST_PREVIEW_PANEL_FOOTER).should('not.exist'); }); - // github.com/elastic/security-team/issues/9933 - // Enable when feature flag 'entityAlertPreviewEnabled' is enabled - it.skip('open user preview when user name is clicked', () => { + it('open user preview when user name is clicked', () => { toggleOverviewTabAboutSection(); toggleOverviewTabInvestigationSection(); toggleOverviewTabInsightsSection();