Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualize] [Lens] Inspector 'filter by' creates a standard filter instead of filtering time range for a time interval #116752

Open
mbondyra opened this issue Oct 29, 2021 · 9 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Inspector Inspector infrastructure and implementations impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)

Comments

@mbondyra
Copy link
Contributor

Kibana version:
7.16, master

Not sure if it's a wanted behavior, so feel free to close it if there's a reason for it.

  1. Open Lens visualization and create a datatable visualization with a timestamp column:

Screenshot 2021-10-29 at 13 03 24

2. Click on 'Inspect' and choose 'filter for value' in any of the intervals:

Screenshot 2021-10-29 at 13 03 57

The filter was added:
Screenshot 2021-10-29 at 13 04 15

Works the same across Lens and Visualize.
What we would like instead probably, is to narrow the timerange in a timepicker, just like it behaves when clicking in a table.

Oct-29-2021.13-05-45.mp4
@mbondyra mbondyra added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Oct 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@mbondyra mbondyra changed the title [Visualize] [Lens] Inspector 'filter by' creates a standard filter instead of time filter for a time interval [Visualize] [Lens] Inspector 'filter by' creates a standard filter instead of filtering time range for a time interval Oct 29, 2021
@flash1293 flash1293 added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Oct 29, 2021
@dej611 dej611 assigned dej611 and unassigned dej611 Dec 29, 2021
@flash1293
Copy link
Contributor

As described here #122113 (comment) , this is blocked on #118851 as we need some additional meta data on the data table to make it work correctly in all cases.

@flash1293
Copy link
Contributor

Actually, this meta data is already available for all cases. If search.aggs.getDateHistogramMetaDataByDatatableColumn(datatableColumn) returns a time range, then this means the column is bound to the global time picker and can change it instead of creating a filter. If it's not returning a time range, then it means a filter needs to be created.

@flash1293
Copy link
Contributor

Just realized this is bigger than VisEditors because this part of the inspector is maintained as part of the data plugin:

id="data.inspector.table.filterForValueButtonTooltip"

@elastic/kibana-app-services Could you take a look at that?

@flash1293 flash1293 added Feature:Inspector Inspector infrastructure and implementations Team:AppServicesSv and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Feb 16, 2022
@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:AppServicesSv labels Mar 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Apr 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@ThomThomson
Copy link
Contributor

Reassigning this to the Data Discovery team because it looks like the change will need to happen in the Data plugin

@KOTungseth KOTungseth added the loe:needs-research This issue requires some research before it can be worked on or estimated label Apr 13, 2023
@lukasolson
Copy link
Member

lukasolson commented Apr 17, 2023

When creating a data view, you select a time field. In my opinion, the type of filter we create should be based on whether or not the field is the selected time field for the data view. Here's the two scenarios:

  1. The date field is the selected time field for the data view - Adjust the time range in the time picker to the selected range.
  2. The date field isn't the selected time field for the data view - Create a filter in the filter bar for the selected range.

I believe this is how it has historically worked, and makes the most sense.

@stratoula
Copy link
Contributor

I agree with you Lukas ++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Inspector Inspector infrastructure and implementations impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants