Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Assistant] Investigate credential hash #123752

Open
alisonelizabeth opened this issue Jan 25, 2022 · 2 comments
Open

[Upgrade Assistant] Investigate credential hash #123752

alisonelizabeth opened this issue Jan 25, 2022 · 2 comments
Labels
chore Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@alisonelizabeth
Copy link
Contributor

In #123727, we made changes to how the credential hash is created in Upgrade Assistant to exclude reindexOptions.

As a follow-up, we should consider whether it would be a better approach to update the credential hash with the new reindexOptions attributes, rather than exclude them.

Related work that likely caused the original issue: #58890, #58890.

@alisonelizabeth alisonelizabeth added chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant labels Jan 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@sebelga
Copy link
Contributor

sebelga commented Jan 26, 2022

I think it would be better to only include in the hash what we know is unique and necessary for the functionality. Adding the full attributes object, including the errorMessage string does not seem robust.

By defining what we need and be explicit about it in the code we will prevent future regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants