Spy Pane in a Tile map sometimes creates empty whitespace

[stacey-gammon]

I noticed a strange interaction with the spy pane and tile maps which only happens very rarely but is causing a flaky test failure. You can see the history of this test failure here in this screenshot:

@nreese just ran into it in one of his PRs and I saw it in another of my PRs today.

So I played around with this test a bit locally and was able to get tilemaps into a strange state where even after hiding the spy pane, it still takes up strange space in the map:

I think we can fix the flaky test by toggling the spy pane, but it is actually a legit bug, just a very hard to reproduce one, so probably not a high priority. Filing to keep track anyhow.

I'll attempt to fix the flaky test in this PR: #13034

cc @elastic/kibana-visualizations

[stacey-gammon]

Turns out once you get into this state it's difficult to get out, and zooming around and toggling the spy does nothing:

I was finally able to get out of this situation by using the draw a rectangle tool, which some how re-centered the map. The problem has something to do with bad data getting in the url, either with the map center or the map bounds.

Here is one of the bad urls where I was able to get into a bad state:
http://localhost:5620/app/kibana?_t=1501119602684#/visualize/create?type=tile_map&indexPattern=logstash-*&_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:'2015-09-19T06:31:44.000Z',mode:absolute,to:'2015-09-23T18:31:44.000Z'))&_a=(filters:!(),linked:!f,query:(language:lucene,query:''),uiState:(mapBounds:(bottom_right:(lat:-9.79567758282973,lon:506.25),top_left:(lat:77.46602847687329,lon:-504.84374999999994)),mapCenter:!(50.28933925329178,0.703125),mapCollar:(bottom_right:(lat:-33.10292,lon:180),top_left:(lat:34.11256,lon:-180),zoom:2),mapZoom:0,spy:(mode:(fill:!f,name:!n))),vis:(aggs:!((enabled:!t,id:'1',params:(),schema:metric,type:count),(enabled:!t,id:'2',params:(autoPrecision:!t,field:geo.coordinates,isFilteredByCollar:!t,precision:1,useGeocentroid:!t),schema:segment,type:geohash_grid)),params:(addTooltip:!t,heatBlur:15,heatMaxZoom:0,heatMinOpacity:0.1,heatRadius:25,isDesaturated:!t,legendPosition:bottomright,mapCenter:!(0,0),mapType:'Scaled%20Circle%20Markers',mapZoom:2,wms:(enabled:!f,options:(format:image%2Fpng,transparent:!t))),title:'New%20Visualization',type:tile_map))

[nreese]

@stacey-gammon Great work. How did you get the map into the broken state?

[stacey-gammon]

@nreese - By copying the url while watching the tests run and seeing it in an invalid state. It was pretty tough to even get the tests to trigger it. Something I suspect to do with zooming in and out with the spy pane open. I changed the test to avoid doing that and it passed once on ci and once on my local, but will need to give it more runs to see if it really did the trick.

[stacey-gammon]

I think you can also trigger it by modifying the url directly and putting in bad values for map bounds or map center lat/long. There isn't a way in the UI to get those to reset properly.