Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map filter not set appropriately when spy panel is open #13625

Closed
stacey-gammon opened this issue Aug 21, 2017 · 2 comments · Fixed by #13678
Closed

Map filter not set appropriately when spy panel is open #13625

stacey-gammon opened this issue Aug 21, 2017 · 2 comments · Fixed by #13678
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent

Comments

@stacey-gammon
Copy link
Contributor

stacey-gammon commented Aug 21, 2017

To reproduce:

  1. Create a coordinate map visualization.
  2. Open the spy pane toggle
  3. Save the map
  4. Add it to a dashboard.

The filter will not be set, in addition I'm having trouble toggling the spy pane after that.

The issue is in maps_visualizations when this._kibanaMap.getUntrimmedBounds(); is called - it returns undefined when the spy pane in the map visualization is opened.

cc @nreese @ppisljar.

screen shot 2017-08-21 at 3 26 05 pm

screen shot 2017-08-21 at 3 26 11 pm

@stacey-gammon stacey-gammon added Feature:Dashboard Dashboard related features Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience :Sharing labels Aug 21, 2017
@ppisljar
Copy link
Member

getUntrimmedBounds() should return maximum bounds if it can't determine the bounds correctly instead of returning undefined.

@nreese
Copy link
Contributor

nreese commented Aug 22, 2017

The bounds get returned but there is not map height (the latitudes are equal for the 2 points).
screen shot 2017-08-22 at 6 51 29 am

In this case, the height will have to be a best guess. Do we know the gridster layout at this point? Maybe the height can be set to the width * the panel width/height ratio. Or, if there is not gridster data, the height could just be set to the width. How does this sound? I can work on the fix, but just want to make sure everyone is ok with the solution first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants