Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Portable Dashboards] Remove Saved Object Class #136767

Closed
ThomThomson opened this issue Jul 20, 2022 · 1 comment · Fixed by #138774
Closed

[Portable Dashboards] Remove Saved Object Class #136767

ThomThomson opened this issue Jul 20, 2022 · 1 comment · Fixed by #138774
Assignees
@cqliu1
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Portable Dashboard Related to the Portable Dashboards initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

The Saved Object Class that dashboard is using in src/plugins/dashboard/public/saved_dashboards/saved_dashboard.ts has been deprecated for quite some time. Every other plugin has migrated to the Saved Objects Client, and it's about time that we do the same.

We should likely look to Lens, to see how their Saved Object is set up.

This issue will likely require more fleshing-out as we look into how this should be done.
@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:large Large Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:Portable Dashboard Related to the Portable Dashboards initiative labels Jul 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson changed the title [Dashboard] Remove Saved Object Class [Portable Dashboards] Remove Saved Object Class Jul 20, 2022
This was referenced Jul 20, 2022
Closed
Closed
@cqliu1 cqliu1 self-assigned this Jul 20, 2022
@ThomThomson ThomThomson mentioned this issue Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cqliu1 cqliu1

Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Portable Dashboard Related to the Portable Dashboards initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Portable Dashboards] Remove Saved Object Class ThomThomson/kibana
3 participants
@cqliu1 @ThomThomson @elasticmachine