Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cases Webhook Connector Follow Ups #137218

Closed
stephmilovic opened this issue Jul 26, 2022 · 2 comments
Closed

Cases Webhook Connector Follow Ups #137218

stephmilovic opened this issue Jul 26, 2022 · 2 comments
Assignees
@stephmilovic
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.4.0

Comments

@stephmilovic
Copy link
Contributor

stephmilovic commented Jul 26, 2022 •
edited
Loading

Follow up items from #131762

Needs unit tests

  • x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/create_connector_flyout/header.tsx
  • x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_type_menu.tsx

Remove real urls

  • x-pack/plugins/actions/server/builtin_action_types/cases_webhook/service.test.ts

Line up URL and method
Image

Add isExperimental flag to:

  • edit connector flyout
  • add connector modal

Rename incidentViewUrl to viewIncidentUrl

Docs
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 26, 2022
@stephmilovic stephmilovic added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed Team:Threat Hunting:Explore v8.4.0 labels Jul 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 26, 2022
@stephmilovic stephmilovic self-assigned this Jul 26, 2022
@stephmilovic stephmilovic mentioned this issue Jul 26, 2022
Merged
@peluja1012 peluja1012 added the Team:Threat Hunting Security Solution Threat Hunting Team label Aug 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephmilovic stephmilovic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.4.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peluja1012 @stephmilovic @elasticmachine