Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] [Infra O11y UI] remove uses of deprecated EUI page with new components introduced in 63.0.0 #140149

Closed
matschaffer opened this issue Sep 7, 2022 · 3 comments
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services technical debt Improvement of the software architecture and operational architecture

Comments

@matschaffer
Copy link
Contributor

matschaffer commented Sep 7, 2022

Description:

Remove usages of EUI *_deprecated components for Page template components and replace them with new page template.

Background:

See this PR for reference: #139524 and #139524 (comment) for a rough migration overview.

From it:

Main EuiPageTemplate release changelog

This component has been replaced (in EUI) with a new flexible namespaced component that utilizes React context to pass through top level props and a new sectioning component that makes it easier to stack page contents including headers in any order.

👉 New component docs: https://elastic.github.io/eui/#/templates/page-template
👉 EUI PR with details: elastic/eui#5768
👉 Guidelines: https://elastic.github.io/eui/#/templates/page-template/guidelines

In addition, the latest update deprecates a lot of (now defunct) page components like EuiPageContent and renames then with _Deprecated. This will hopefully alert owners that they should be switching to the latest template paradigm.

@matschaffer matschaffer added Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring labels Sep 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@smith smith added the technical debt Improvement of the software architecture and operational architecture label Sep 7, 2022
@roshan-elastic
Copy link

Closing for the moment as @matschaffer has left.

We need to understand the benefit of doing this in more detail before we can have this on the backlog. For example:

  • Which page does this affect?
  • What benefits will we gain?

@roshan-elastic roshan-elastic closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2023
@roshan-elastic
Copy link

@weltenwort - Apologies, I can see this affects Logs UI too...feel free to re-open if you think this is a priority for Logs UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

4 participants