Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable] Provide unified error UI #141676

Closed
dokmic opened this issue Sep 23, 2022 · 2 comments · Fixed by #143367
Closed

[Embeddable] Provide unified error UI #141676

dokmic opened this issue Sep 23, 2022 · 2 comments · Fixed by #143367
Labels
Feature:Embedding Embedding content via iFrame Feature:Lens Feature:Vis Editor Visualization editor issues impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@dokmic
Copy link
Contributor

dokmic commented Sep 23, 2022 •
edited
Loading

Describe the feature:

There was a discussion in #140205, and the suggestion from the @elastic/kibana-design was to reuse EuiEmptyPrompt to render error messages.

  • The error component in the embeddable plugin should be updated accordingly to the suggestion.
  • At the moment, Lens is encapsulating an error state. So either the error component inside the Lens plugin should be updated, or the Lens embeddable should update the error state correctly. The second option is preferable as it will be possible to show the CTA button in the edit mode.
  • The visualizations plugin is showing a custom error UI. Most likely, the renderError lifecycle hook can be safely removed, and the UI can reuse the error component in the editor.
@dokmic dokmic added Feature:Embedding Embedding content via iFrame loe:medium Medium Level of Effort Feature:Vis Editor Visualization editor issues Feature:Lens Team:AppServicesUx labels Sep 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@dokmic
Copy link
Contributor Author

dokmic commented Sep 23, 2022

cc @elastic/kibana-presentation @elastic/kibana-vis-editors

@dokmic dokmic mentioned this issue Sep 23, 2022
Merged
1 task
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed loe:medium Medium Level of Effort impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Sep 26, 2022
@dokmic dokmic mentioned this issue Oct 14, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame Feature:Lens Feature:Vis Editor Visualization editor issues impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Embeddable] Add unified error UI dokmic/kibana
2 participants
@dokmic @elasticmachine