Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the optimizer #14477

Closed
spalger opened this issue Oct 17, 2017 · 6 comments
Closed

Optimize the optimizer #14477

spalger opened this issue Oct 17, 2017 · 6 comments
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@spalger
Copy link
Contributor

spalger commented Oct 17, 2017

To dramatically decrease the file count and improve startup performance we should bundle the optimizer into a single is file.

@spalger spalger changed the title Optimizer the optimizer Optimize the optimizer Oct 17, 2017
@jbudz jbudz added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 25, 2017
@mkozjak
Copy link

mkozjak commented Apr 9, 2018

Half a year later, we're still having an 'optimizer' 'optimizing' things for 10 mins.

{“type”:“log”,“@timestamp”:“2018-04-09T07:48:16Z”,“tags”:
[“info”,“optimize”],“pid”:9017,“message”:“Optimization of bundles for stateSessionStorageRedirect, 
status_page, timelion, sentinl, uauth and kibana complete in 600.08 seconds”}

Hooray!!

@matskmpbs
Copy link

I am upgrading kibana across our UAT and production stacks, and just the unpack of the kibana zip takes absolutely ages because of the file count. Please reduce!

@schlangz
Copy link

schlangz commented Jun 5, 2020

Over 1 year later nothing has changed

@pgayvallet
Copy link
Contributor

Closing, no longer relevant as the optimizer will no longer be shipped after the legacy platform removal is complete.

@realChevChelios
Copy link

Extracting this on Windows is brutal. The optimizer is the reason for so many files? What is the optimizer? When will it be removed?

@spalger
Copy link
Contributor Author

spalger commented Jul 31, 2020

Using node.js and a hefty number of node modules is the real reason for so many files. I'm working on removing the optimizer in #73154 and we're constantly trying to find ways to improve accountability and awareness of how many files are created in node_modules as the project grows, but still working on concrete ways to improve that.

That said, I've heard that 7zip provides much better extraction performance on windows than the standard windows archive extraction tools, something to keep in mind if you're regularly extracting Kibana distributables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

7 participants