Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] view data in Discover without opening a new tab #153247

Closed
Tracked by #184459
drewdaemon opened this issue Mar 16, 2023 · 6 comments
Closed
Tracked by #184459

[Lens] view data in Discover without opening a new tab #153247

drewdaemon opened this issue Mar 16, 2023 · 6 comments
Labels
enhancement New value added to drive a business result Feature:Lens 🧊 iceboxed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@drewdaemon
Copy link
Contributor

Describe the feature:
When you view Discover data in Lens, Kibana does it in the same window. Then, when you click "view data in discover" to go back, you get a new tab.

The navigation strategies should match so that it feels more seamless.

@drewdaemon drewdaemon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Mar 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@drewdaemon drewdaemon added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Mar 17, 2023
@stratoula stratoula added enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Mar 21, 2023
@stratoula
Copy link
Contributor

I think that the reason that the team decided to do it like that back then is because it would make it easier for the user to have both Lens and Discover open, otherwise we should provide a way to go back to Lens. We can re-consider here,

@ninoslavmiskovic
Copy link
Contributor

I agree with @drewdaemon here and thank you for the context @stratoula. Let us make it consistent. This way the user does not get lost.

Currently, if the user is clicking on "Visualize" on a field in Discover it opens in the same tab and the user can go back via the browser from Lens. The same goes for "open in lens" via the histogram. This flow is lost when the user goes from Explore data in Discover (in the top nav) and via the field list "Explore in Discover".

The proposal is that we open in the same tab when the user clicks on both "Explore data in Discover" in top nav and on "Explore in Discover" on the field list:

Skærmbillede 2023-03-21 kl  09 10 02

Skærmbillede 2023-03-21 kl  09 09 59

@dej611
Copy link
Contributor

dej611 commented Mar 21, 2023

I think that the reason that the team decided to do it like that back then is because it would make it easier for the user to have both Lens and Discover open, otherwise we should provide a way to go back to Lens. We can re-consider here,

Yes, can confirm this. During the implementation there has been a discussion on the topic for this same reason.

I think the use case of Explore data in Discover is slightly different from the others, i.e. dashboard panel => discover, Lens field list => Discover.

The main concern here is to lose the analysis context, which might have required some time to setup.
So here some ideas:

  • unless the visualization has been already saved, prompt the user to save the chart like a regular navigation action
  • introduce the Back to Lens button in Discover which would preserve the Lens visualization state so the user can do back and forth at will

@stratoula
Copy link
Contributor

Yes as Marco said it is a bit different. The url from the field list navigates to the same tab as it displays the field as a column on Discover. The top nav renders the visualizations columns so we should have a strategy of "not losing the viz" when going back.

@markov00
Copy link
Member

markov00 commented Jun 3, 2024

In order to provide better transparency of priorities, issues that will not be prioritized within the next 24 months are being closed.

Tracking request in Lens general improvements ice box #184459

@markov00 markov00 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens 🧊 iceboxed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants