Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Migrate all usages of EuiPage*_Deprecated #161414

Closed
Tracked by #161872
cee-chen opened this issue Jul 7, 2023 · 3 comments · Fixed by #163482
Closed
Tracked by #161872

[Enterprise Search] Migrate all usages of EuiPage*_Deprecated #161414

cee-chen opened this issue Jul 7, 2023 · 3 comments · Fixed by #163482

Comments

@cee-chen
Copy link
Member

cee-chen commented Jul 7, 2023

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have 7 usages of EuiPage*_Deprecated components, which you can find listed here:

https://github.com/search?q=repo%3Aelastic%2Fkibana+%2FEuiPage%5Ba-zA-Z%5D%2B_Deprecated%2F+path%3A%2F%5Ex-pack%5C%2Fplugins%5C%2Fenterprise_search%2F&type=code

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!

@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen
Copy link
Member Author

cee-chen commented Jul 7, 2023

Pinging @elastic/enterprise-search-frontend

@poremland
Copy link

Enterprise Search GH issue tracking the work.

@saarikabhasi saarikabhasi linked a pull request Aug 10, 2023 that will close this issue
2 tasks
@saarikabhasi saarikabhasi self-assigned this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants