Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for script to be selected from dropdown in Visualize #1755

Closed
rashidkpc opened this issue Oct 27, 2014 · 2 comments
Closed

Allow for script to be selected from dropdown in Visualize #1755

rashidkpc opened this issue Oct 27, 2014 · 2 comments

Comments

@rashidkpc
Copy link
Contributor

The user should be able to input a script to be used for calculating the values of an aggregation. Because of the potential for class casting exceptions when a script is specified along with a field, we should not be sending a field when a script is in use.

@w33ble
Copy link
Contributor

w33ble commented Oct 28, 2014

There's a lot of stuff that needs to happen given the current plan of attack. It's highly related to #1537 and is more about how the interface for scripts will work, and not so much about their implementation.

Currently, we'll planning to add a _script option to the field selection, and show a script input in the agg builder if selected. This seems pretty easy on the surface, but the change is pretty far reaching, since the vislib, the agg builder and basically everything else all expects the aggConfig.params to contain a field, which script queries will not have.

Most parts use the field param for displaying (ie. labels) - this may be solved by saved scripted fields, assuming we're going to require a name for every script that's used.

@w33ble w33ble assigned w33ble and unassigned rashidkpc Nov 12, 2014
@rashidkpc rashidkpc removed this from the 4.0.0-BETA3 milestone Dec 5, 2014
@w33ble
Copy link
Contributor

w33ble commented Dec 8, 2014

Closing as part of #1537

@w33ble w33ble closed this as completed Dec 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants