Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console][Monaco] No contrast between selected text and current line colors #186772

Closed
sakurai-youhei opened this issue Jun 23, 2024 · 2 comments · Fixed by #189060
Closed

[Console][Monaco] No contrast between selected text and current line colors #186772

sakurai-youhei opened this issue Jun 23, 2024 · 2 comments · Fixed by #189060
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@sakurai-youhei
Copy link
Member

Kibana version: 74a202a

Elasticsearch version: 8.15.0-SNAPSHOT

Server OS version: Linux wsl 5.15.146.1-microsoft-standard-WSL2 #1 SMP Thu Jan 11 04:09:03 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Browser version: Chrome Version 126.0.6478.63 (Official Build) (64-bit)

Browser OS version: Windows 11 10.0.22621 N/A Build 22621

Original install method (e.g. download page, yum, from source, etc.): Build from source

Describe the bug: It's pretty hard (or impossible) to distinguish selected text in the current line due to no contrast in the text & background colors.

Steps to reproduce:

  1. Go to Kibana > Dev Tools > Console.
  2. Type in GET 1234567890.
  3. Select a part of the text from 2 to 0.

Expected behavior:

The selected part should be obvious like 8.14.1 below.
selected-8141

Screenshots (if relevant):
selected-main

@sakurai-youhei sakurai-youhei added bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature labels Jun 23, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 23, 2024
@jughosta jughosta added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Jun 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 23, 2024
@sakurai-youhei
Copy link
Member Author

The editor.selectionBackground has been set to #343551 (dark theme) and #E3E4ED (light theme) since ebe22f468b0d47ed5853cb89de2a28439caa0c5b, while the selected line's background color is transparentized #343741 (dark theme) and #D3DAE6 (light theme). That's why it is hard to distinguish two colors.

/*
* The highlighting for the selected requests in the monaco editor
*/
.console__monaco_editor__selectedRequests {
background: transparentize($euiColorLightShade, .3);
}

https://github.com/elastic/eui/blob/a7f6d8479de9402b48673d38e84116ace54fbf35/packages/eui/src/themes/amsterdam/_colors_dark.scss#L22

https://github.com/elastic/eui/blob/a7f6d8479de9402b48673d38e84116ace54fbf35/packages/eui/src/themes/amsterdam/_colors_light.scss#L22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
4 participants