Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry opt-in setting #22144

Closed
legrego opened this issue Aug 17, 2018 · 6 comments
Closed

Telemetry opt-in setting #22144

legrego opened this issue Aug 17, 2018 · 6 comments

Comments

@legrego
Copy link
Member

legrego commented Aug 17, 2018

The Spaces plugin will be making the Advanced UI Settings space-aware. There are a couple of UI Settings that do not make sense to be space-specific, such as telemetry:optIn. The decision to enable telemetry should be made for the entire Kibana instance, rather than for each individual space within the instance.

Instead of supporting one-off cases for specific configuration settings like this one, we are proposing that we remove the telemetry:optIn setting from the config document in favor of a dedicated document in the .kibana index which tracks the telemetry opt-in preference.

Given this, we propose the following:

  1. On Kibana server startup, migrate the user's existing telemetry:optIn preference (if set) to the dedicated 'telemetry' document
  2. Expose a set of read/write API Endpoints for the new 'telemetry' document
  3. Create a new screen in the Management section to configure the telemetry decision.
  4. Update the opt-in banner and telemetry collector to use the new API Endpoints.

Since the monitoring xpack-main plugin writes the current telemetry settings, we propose making these changes within the monitoring xpack_main plugin, with the understanding that a dedicated telemetry plugin may be created in the future.

@kobelb @tsullivan @pickypg

@pickypg
Copy link
Member

pickypg commented Aug 17, 2018

Technically, xpack_main writes these settings now.

@jbudz
Copy link
Member

jbudz commented Aug 17, 2018

Could this be generalized to config and admin config? I expect there's a few others, like xpack:defaultAdminEmail.

@legrego
Copy link
Member Author

legrego commented Aug 17, 2018

@jbudz we are trying to avoid this generalization, since this adds additional complexity when securing access to these settings. We have a similar proposal for xpack:defaultAdminEmail here.

@kobelb
Copy link
Contributor

kobelb commented Aug 17, 2018

Could this be generalized to config and admin config? I expect there's a few others, like xpack:defaultAdminEmail.

We might need this long-term, but the difference between this setting and the xPack:defaultAdminEmail is we want anyone to be able opt into telemetry, where-as the xPack:defaultAdminEmail really should only be set by "administrators".

@kobelb
Copy link
Contributor

kobelb commented Aug 17, 2018

Also, we could technically leave telemetry alone and allow users to opt into it "per space", even though the stats that would be reported would be for all spaces.

@epixa
Copy link
Contributor

epixa commented Aug 21, 2018

I'm all for this proposal, but let's manage it from xpack_main rather than monitoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants