Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a filter added via the + loupe, then editing it raises an exception #30245

Closed
webmat opened this issue Feb 6, 2019 · 4 comments · Fixed by #45259
Closed

Editing a filter added via the + loupe, then editing it raises an exception #30245

webmat opened this issue Feb 6, 2019 · 4 comments · Fixed by #45259
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:Filters Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@webmat
Copy link

webmat commented Feb 6, 2019

Kibana version:

Version: 7.0.0-SNAPSHOT
Build: 22452

Elasticsearch version:

number: "7.0.0-SNAPSHOT",
build_flavor: "default",
build_type: "tar",
build_hash: "638ba4a",
build_date: "2019-02-05T13:49:29.097757Z",
build_snapshot: true,
lucene_version: "8.0.0",
minimum_wire_compatibility_version: "6.7.0",
minimum_index_compatibility_version: "6.0.0-beta1"

Server OS version:

Docker image used by Beats CI

Browser version:

Google Chrome | 71.0.3578.98 (Official Build) (64-bit)
Revision | 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
JavaScript | V8 7.1.302.31

Browser OS version:

(say in a suave voice) Mojave!
10.14.2 (18C54)

Original install method (e.g. download page, yum, from source, etc.):

Beats Docker CI

Describe the bug:

Adding a filter on a field of datatype long via the loupe, then editing it leads to an exception.

Steps to reproduce:

  1. Find a dataset with long fields in Discover
  2. Click the (+) loupe to filter on a field of datatype long
  3. Edit the filter

Expected behavior:

The edit UI should show up.

Screenshots (if relevant):

Instead, this error is shown:

screenshot 2019-02-06 10 01 34

Errors in browser console (if relevant):

Uncaught TypeError: searchValue.toLowerCase is not a function (http://localhost:5601/built_assets/dlls/vendors.bundle.dll.js:203)
Version: 7.0.0-SNAPSHOT
Build: 22452
Error: Uncaught TypeError: searchValue.toLowerCase is not a function (http://localhost:5601/built_assets/dlls/vendors.bundle.dll.js:203)
    at window.onerror (http://localhost:5601/bundles/commons.bundle.js:3:1032352)

Provide logs and/or server output (if relevant):

Any additional context:

It's important to do this on a long field. Text fields don't have this problem.

@kindsun kindsun added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application labels Feb 6, 2019
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Aug 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@dkngyn
Copy link

dkngyn commented Aug 21, 2019

searchValue.toLowerCase references to EuiComboBox in this case I believe
Possible fix is to stringify the label in phrase_value_input.tsx#L71 where getLabel={option => String(option)}. It seems like it was mishandled? The same for phrases_values_input.tsx#L51.

@kertal
Copy link
Member

kertal commented Sep 9, 2019

dear @dkngyn, sounds like a valid approach to solve it, problem is, I can't reproduce it, created a dataset with long value, added a filter, I could edit it. in 7.0.0, 7.2.0, 7.3.1. So I'd need more infos about how the filter is created? thx a lot!

@webmat
Copy link
Author

webmat commented Sep 12, 2019

I tried it on 7.3.1, and indeed it seems like it's fine now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:Filters Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
6 participants