-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate a static filesystem for node modules with kibana #43357
Comments
Pinging @elastic/kibana-operations |
I've updated the issue with some recent benchmarks I collected after the integration |
is there an evaluation for runtime performance? E.g. I'm iterating through files in a non node_module folder, will it get slower? |
@zfy0701 I currently don't have written down data for it, but on my manual tests I didn't found any evidence of a bad performance impact. Other good evidence is that on the PR with the integration with kibana, the global ci running time was even lower than the last days average (I guess it was happening due to an improvement I did when reading streams from the static-fs) |
That issue aims to solve the problems highlighted on #11783.
We wanna ship the Kibana's node_modules inside a static filesystem so we can decrease the number of files into our distributable, avoid problems like the max path length and the creation of a service (on windows) as well as decrease the amount of time needed for decompressing.
Related to #27466
Related to #34016
Blocks #6218
== Benchmark ==
I've collect some benchmarks when using a static-fs with Kibana.
The hardware used was:
Computer: Custom Windows Box
OS: Windows 10 64bits
Processor: 3,7 GHz AMD Ryzen 2700x
Memory: 16 GB 2933 MHz DDR4
Disk: SSD 500GB NVMe
The text was updated successfully, but these errors were encountered: