New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] change equals check for mapbox filter expressions #53246

Closed

nreese opened this issue Dec 17, 2019 · 1 comment · Fixed by #99673

Labels

chore [Deprecated-Use Team:Presentation]Team:Geo

Contributor

nreese commented Dec 17, 2019

from #52957 (comment)

in hindsight, this reference-equality check is imho not best practice. it relies on mb keeping the reference to the filter, which isn't documented.
Consider using _.isEqual, and then change in the other mbSync methods too

nreese added chore [Deprecated-Use Team:Presentation]Team:Geo labels

Contributor

elasticmachine commented Dec 17, 2019

Pinging @elastic/kibana-gis (Team:Geo)

nreese changed the title ~~[Maps] change equals check for style filters~~ [Maps] change equals check for mapbox filter expressions

nreese mentioned this issue

[Maps] Label style properties #52957

Merged

nreese mentioned this issue

[Maps] timeslider #96791

Closed

nreese mentioned this issue

[Maps] use deep equals for mapbox filter expression equals check #99673

Merged

nreese closed this as completed in #99673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment