[Logs / Metrics UI] [NP followup] Cleanup /common

[Kerry350]

In new platform world a (sensible) restriction is made that you can't just import any old code from inside of a plugins server and client folders, you may only import from the top level index (i.e. code that is in a contract to share with others).

However, this rule also applies to our own common folder. For now// eslint-disable-next-line @kbn/eslint/no-restricted-paths rules have been added to all the locations where files in our common folder import from server or client. This isn't 100% ideal as theoretically another plugin could come along and import from here now, however we should be okay as our common folder is just common code for us. Moving forward we should refactor these uses - code that lives within common shouldn't be importing from client or server as it no longer makes it common. We should move towards this being for strictly common code (things like HTTP API types). As an example - we currently have React components living within common, these should definitely move to public and so on.

This ticket can also just be approached in an "as we go" manner. If you're working on some code that somehow touches things in /common, try and cleanup some references.

[elasticmachine]

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

[smith]

Not sure if we need to do anything here. Closing.