Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs / Metrics UI] [NP followup] Fix navigation within the same app via the Kibana nav bar #58112

Closed
Kerry350 opened this issue Feb 20, 2020 · 2 comments · Fixed by #61667
Closed

[Logs / Metrics UI] [NP followup] Fix navigation within the same app via the Kibana nav bar #58112

Kerry350 opened this issue Feb 20, 2020 · 2 comments · Fixed by #61667
Assignees
@Kerry350
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@Kerry350
Copy link
Contributor

Kerry350 commented Feb 20, 2020 •
edited by sgrodzicki
Loading

Currently if you are already within the metrics or logs app, and then try to click the same app again within the Kibana side navigation, the route will not re-render (so if you were on the /metrics/explorer page and clicked the Metrics icon in the Kibana navigation the /metrics route won't render).

This is due to #53692 and will be fixed with #56705. Once #56705 is completed, the implementation of this ticket should be to switch to the new ScopedHistory.
@Kerry350 Kerry350 added Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Feb 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Kerry350 Kerry350 mentioned this issue Feb 20, 2020
Closed
11 tasks
@Dosant Dosant mentioned this issue Feb 21, 2020
Closed
@joshdover
Copy link
Contributor

ScopedHistory has been merged, should be able to switch over now in Metrics and Logs routers 😄

@Kerry350 Kerry350 mentioned this issue Mar 5, 2020
Merged
@Kerry350 Kerry350 self-assigned this Mar 26, 2020
@Kerry350 Kerry350 mentioned this issue Apr 2, 2020
Merged
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Apr 22, 2020
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kerry350 Kerry350

Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs / Metrics UI] Switch to scopedHistory and enhance useLinkProps hook Kerry350/kibana
4 participants
@Kerry350 @sgrodzicki @joshdover @elasticmachine