Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs / Metrics UI] [NP followup] Review index.scss styles #58114

Closed
Kerry350 opened this issue Feb 20, 2020 · 1 comment · Fixed by #58219
Closed

[Logs / Metrics UI] [NP followup] Review index.scss styles #58114

Kerry350 opened this issue Feb 20, 2020 · 1 comment · Fixed by #58219
Assignees
@Kerry350
Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@Kerry350
Copy link
Contributor

Kerry350 commented Feb 20, 2020 •
edited by zube bot
Loading

Previously our index.scss file was handled by a uiExports styleSheetPaths key. This index.scss file is still in our codebase, but isn't being bundled, so isn't applying any styles.

We have very few styles in this file. This ticket should review those styles and A) Delete the ones that aren't needed and B) Import the ones that are needed (sass files can now be imported like any other module, so we should be able to just import index.scss directly at the top level application component).

Linked to: #58104
@Kerry350 Kerry350 added Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Feb 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Kerry350 Kerry350 mentioned this issue Feb 20, 2020
Closed
11 tasks
@Kerry350 Kerry350 self-assigned this Feb 20, 2020
@Kerry350 Kerry350 mentioned this issue Feb 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kerry350 Kerry350

Labels
Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs / Metrics UI] Handle index.scss Kerry350/kibana
2 participants
@Kerry350 @elasticmachine