Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved semantics for esaggs function #61768

Closed
8 tasks done
ppisljar opened this issue Mar 30, 2020 · 1 comment · Fixed by #84973
Closed
8 tasks done

improved semantics for esaggs function #61768

ppisljar opened this issue Mar 30, 2020 · 1 comment · Fixed by #84973
Assignees
Labels
blocked Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)

Comments

@ppisljar
Copy link
Member

ppisljar commented Mar 30, 2020

esaggs function semantics needs improvements. it should not accept any json blob parameters. Instead we should rather create utility functions.

  • make esaggs accept aggs parameter which is array of agg_type
    • Add a toExpressionAst method to handle serializing an agg config into an AST
    • Create interface to serve as a mapping of all agg type params
    • Add aggTerms function as an example
    • bucket agg functions (21 agg types)
    • metric agg functions (11 agg types)
  • make esaggs accept index parameter which is the return value of type index_pattern from indexPatternLoad
    • since we will already need to update downstream uses of esaggs, we can look for other expression functions that use index pattern IDs to instead take in indexPatternLoad. For items that can't be changed at once, follow up issues should be created.
  • update downstream uses of esaggs (mostly build pipeline and lens)

parent issue #46902

@ppisljar ppisljar added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Mar 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers self-assigned this Apr 6, 2020
@lukeelmers lukeelmers added blocked and removed Meta labels Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants