Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Provide consistent messaging when user has read-only permissions #67884

Closed
spong opened this issue Jun 1, 2020 · 11 comments
Closed

[SIEM] Provide consistent messaging when user has read-only permissions #67884

spong opened this issue Jun 1, 2020 · 11 comments
Assignees
Labels
enhancement New value added to drive a business result Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM

Comments

@spong
Copy link
Member

spong commented Jun 1, 2020

When a user has read-only permissions to certain pieces of functionality we have different messaging and warning/info callouts. These callouts also re-appear on each page load, which can be disruptive to read-only users and on demo deployments.

Perhaps we can standardize on the blue info callout, and persist the dismissal of the callout to local storage so it is not shown for the remainder of the user's session.

cc @MikePaquette @benskelker @EthanStrider

Detection Engine:
Banner: Warning/Yellow

Signals index permissions required You are currently missing the required permissions to update signals. Please contact your administrator for further assistance

Timeline
Banner: Warning/Yellow

You require permission to auto-save timelines within the SIEM application, though you may continue to use the timeline to search and filter security events

Case
Banner: Info/Blue

You have read-only feature privileges You are only allowed to view cases. If you need to open and update cases, contact your Kibana administrator

@spong spong added enhancement New value added to drive a business result Team:SIEM labels Jun 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@EthanStrider
Copy link

++ Very nice suggestion. I like the idea of persisting in local storage. It will make for a much better user experience.

@benskelker
Copy link
Contributor

Thanks @spong - initial suggestions:

Cases

You cannot open new or update existing cases
You only have permissions to view cases. If you need to open and update cases, contact your Kibana administrator.

Signals

You cannot change signal states
You only have permissions to view signals. If you need to update signal states (open or close signals), contact your Kibana administrator.

Timeline

You cannot save timelines
You can use Timeline to investigate events, but you do not have the required permissions to save timelines for future use. If you need to save timelines, contact your Kibana administrator.

@cnasikas
Copy link
Member

cnasikas commented Jun 23, 2020

This PR #68372 persists the dismissal of case's callouts to local storage. It can be used by signals and probably by the timeline. @spong I can work on this issue in this PR and fix coloring and context.

@cnasikas cnasikas self-assigned this Jun 23, 2020
@XavierM
Copy link
Contributor

XavierM commented Jun 23, 2020

For the timeline's call out, the team agreed that it should always be there so user know that it is not being persisted.
For case's call out, we agreed that we should only do it for info call out and we will keep the other ones since it can be an error/warning that we want the user to be aware of.

@cnasikas
Copy link
Member

cnasikas commented Jun 27, 2020

Resolved by #68372

Only cases' info callouts are being persistent to the local storage. The PR introduces a new hook where other sub plugins, like Alerts, can use it to persist their callouts to their needs.

@threat-punter
Copy link

@XavierM the call out in the attached image is loaded each time the Cases tab is loaded. Is this expected behavior?

image

@cnasikas
Copy link
Member

cnasikas commented Oct 8, 2020

@threat-punter Yes, this is expected behavior. For cases, only the info callouts (blue) are being persistent in the local storage. Warning (yellow) and error (red) messages are loaded each time.

@threat-punter
Copy link

Thanks for confirming that, @cnasikas

@cnasikas
Copy link
Member

cnasikas commented Oct 8, 2020

@spong Should we close this issue?

@spong
Copy link
Member Author

spong commented Oct 8, 2020

Yeah I think so @cnasikas. @threat-punter we have this issue (#76587) for changing those callouts from warning to info so their dismissal will be persisted (to improve UX for less-permissive users and on demo.elastic.co / events like CTF :)

@spong spong closed this as completed Oct 8, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM
Projects
None yet
Development

No branches or pull requests

8 participants