Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/optimizer] style performance improvements and expanded v8 theme support #70353

Closed
4 tasks done
spalger opened this issue Jun 30, 2020 · 1 comment · Fixed by #70389
Closed
4 tasks done

[kbn/optimizer] style performance improvements and expanded v8 theme support #70353

spalger opened this issue Jun 30, 2020 · 1 comment · Fixed by #70389
Assignees
Labels
enhancement New value added to drive a business result Meta Team:Operations Team label for Operations Team v7.9.0

Comments

@spalger
Copy link
Contributor

spalger commented Jun 30, 2020

The @kbn/optimizer is currently building light and dark versions of every .scss stylesheet in the Kibana repo every time the optimizer is run, regardless of whether developers every need the dark mode styles. This slows down development and would be much worse when we start building 8.0 versions of these styles too.

In order to expand support for more v8 theme development and to get some needed performance improvements in the @kbn/optimizer we are planning to limit the number of style variations the @kbn/optimizer will create by default, while enabling it to make more variations. We'll do this by introducing a KBN_STYLE_THEME environment variable that the @kbn/optimizer will read. It's default value will be v7light, it can be set to * or a comma separated list of v7light, v7dark, v8light, and v8dark.

When a developer switches to a theme that is not being built an error will be thrown in the browser instructing the user how to fix the issue, so it should be relatively easy to discover why things aren't working.

@spalger spalger added Team:Operations Team label for Operations Team Meta enhancement New value added to drive a business result v7.9.0 labels Jun 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Meta Team:Operations Team label for Operations Team v7.9.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants