[Observability] Overview page API responses for UX do not correspond to expected interface

[justinkambic]

Kibana version:

master

Elasticsearch version:

master

Server OS version:

macOS

Browser version:

Recent chrome

Browser OS version:

macOS

Original install method (e.g. download page, yum, from source, etc.):

from source

Describe the bug:

The Observability overview sections use types that annotate the expected shape of API responses. The UX dashboard has an extra hasData key wrapping its data flag, and this is causing TS errors.

Steps to reproduce:

1. Run node scripts/type_check.ts

Expected behavior:

The API should respond with a objects matching the expected interface.

Screenshots (if relevant):
N/A

Errors in browser console (if relevant):
N/A

Provide logs and/or server output (if relevant):

ERROR x-pack/test failed
      x-pack/plugins/observability/public/pages/overview/data_sections.tsx:67:23 - error TS2339: Property 'hasData' does not exist on type 'HasDataResponse'.
        Property 'hasData' does not exist on type 'false'.

      67         {hasData?.ux?.hasData && (
                               ~~~~~~~

      x-pack/plugins/observability/public/pages/overview/index.tsx:92:28 - error TS2339: Property 'hasData' does not exist on type 'HasDataResponse'.
        Property 'hasData' does not exist on type 'false'.

      92       return !hasData[id]?.hasData;
                                    ~~~~~~~


      Found 2 errors.


ERROR x-pack failed
      x-pack/plugins/apm/e2e/tmp/apm-integration-testing/scripts/kibana/validate-ts-interfaces-against-apm-server-sample-docs/scripts/download-sample-docs.ts:1:22 - error TS7016: Could not find a declaration file for module 'prettier'. '/Users/jk/git/justinkambic/kibana/node_modules/prettier/index.js' implicitly has an 'any' type.
        Try `npm install @types/prettier` if it exists or add a new declaration (.d.ts) file containing `declare module 'prettier';`

      1 import prettier from 'prettier';
                             ~~~~~~~~~~

      x-pack/plugins/observability/public/pages/overview/data_sections.tsx:67:23 - error TS2339: Property 'hasData' does not exist on type 'HasDataResponse'.
        Property 'hasData' does not exist on type 'false'.

      67         {hasData?.ux?.hasData && (
                               ~~~~~~~

      x-pack/plugins/observability/public/pages/overview/index.tsx:92:28 - error TS2339: Property 'hasData' does not exist on type 'HasDataResponse'.
        Property 'hasData' does not exist on type 'false'.

      92       return !hasData[id]?.hasData;
                                    ~~~~~~~


      Found 3 errors.

Any additional context:
I do not want to modify the API after feature freeze for the 7.10.0 release. I am planning to suppress the errors for an unrelated bug fix; we should modify the API to return the correct values for the 7.11.0 release.

[elasticmachine]

Pinging @elastic/uptime (Team:uptime)