Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If you click edit on shared iframe and then click cancel - top nav bar, time filter and query bar disappears from the frame #87948

Closed
Tracked by #168126
bhavyarm opened this issue Jan 12, 2021 · 6 comments
Closed
Tracked by #168126

If you click edit on shared iframe and then click cancel - top nav bar, time filter and query bar disappears from the frame #87948

bhavyarm opened this issue Jan 12, 2021 · 6 comments
Labels
blocked bug Fixes for quality problems that affect the customer experience Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Jan 12, 2021 •
edited
Loading

Kibana version: 7.11.0 latest snapshot

Elasticsearch version: 7.11.0 latest snapshot

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: If user shares iframe through embeddable iframe and includes top menu - clicking on edit on shared iframe and cancel - makes the top nav and other shared attributes disappear. Only add filter remains.

Please note to reproduce this bug - you can change the panel title on one of the panels and then cancel it and then poof the top bar, timepicker everything disappears.

Screenshots (if relevant):

topshare

Errors in browser console (if relevant):

Uncaught RangeError: Maximum call stack size exceeded
    at t.__tryOrUnsub (localhost:5601/37694/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21)
    at t.next (localhost:5601/37694/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21)
    at t._next (localhost:5601/37694/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21)
    at t.next (localhost:5601/37694/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:21)
    at t.next (localhost:5601/37694/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:283)
    at t.next (localhost:5601/37694/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:298)
    at dashboard_container_DashboardContainer.onResetInput (localhost:5601/37694/bundles/plugin/embeddable/embeddable.plugin.js:6)
    at dashboard_container_DashboardContainer.onInputChanged (localhost:5601/37694/bundles/plugin/embeddable/embeddable.plugin.js:6)
    at dashboard_container_DashboardContainer.updateInput (localhost:5601/37694/bundles/plugin/embeddable/embeddable.plugin.js:6)
    at localhost:5601/37694/bundles/plugin/dashboard/dashboard.chunk.1.js:1

uiActions.plugin.js:1 Uncaught (in promise) RangeError: Maximum call stack size exceeded
    at new Promise (<anonymous>)
    at Object.<anonymous> (uiActions.plugin.js:1)
    at Object.getActions (uiActions.plugin.js:1)
    at _callee4$ (embeddable.plugin.js:6)
    at l (kbn-ui-shared-deps.js:321)
    at Generator._invoke (kbn-ui-shared-deps.js:321)
    at Generator.forEach.e.<computed> [as next] (kbn-ui-shared-deps.js:321)
    at embeddable_panel_asyncGeneratorStep (embeddable.plugin.js:6)
    at _next (embeddable.plugin.js:6)
    at embeddable.plugin.js:6
embeddable_panel_asyncGeneratorStep @ embeddable.plugin.js:6
_throw @ embeddable.plugin.js:6
Promise.then (async)
embeddable_panel_asyncGeneratorStep @ embeddable.plugin.js:6
_next @ embeddable.plugin.js:6
(anonymous) @ embeddable.plugin.js:6
(anonymous) @ embeddable.plugin.js:6
refreshNotifications @ embeddable.plugin.js:6
_callee6$ @ embeddable.plugin.js:6
l @ kbn-ui-shared-deps.js:321
(anonymous) @ kbn-ui-shared-deps.js:321
forEach.e.<computed> @ kbn-ui-shared-deps.js:321
embeddable_panel_asyncGeneratorStep @ embeddable.plugin.js:6
_next @ embeddable.plugin.js:6
(anonymous) @ embeddable.plugin.js:6
(anonymous) @ embeddable.plugin.js:6
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
t.next @ kbn-ui-shared-deps.js:298
onResetInput @ embeddable.plugin.js:6
onInputChanged @ embeddable.plugin.js:6
updateInput @ embeddable.plugin.js:6
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
handleDashboardContainerChanges @ dashboard.chunk.1.js:1
(anonymous) @ dashboard.chunk.1.js:1
t.__tryOrUnsub @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t._next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:21
t.next @ kbn-ui-shared-deps.js:283
Promise.then (async)
(anonymous) @ dashboard.chunk.1.js:1
exitEditMode @ dashboard.chunk.1.js:1
handleClick @ navigation.plugin.js:6
m @ kbn-ui-shared-deps.js:375
S @ kbn-ui-shared-deps.js:375
(anonymous) @ kbn-ui-shared-deps.js:375
x @ kbn-ui-shared-deps.js:375
M @ kbn-ui-shared-deps.js:375
O @ kbn-ui-shared-deps.js:375
w @ kbn-ui-shared-deps.js:375
Tn @ kbn-ui-shared-deps.js:375
ce @ kbn-ui-shared-deps.js:375
Mn @ kbn-ui-shared-deps.js:375
Ln @ kbn-ui-shared-deps.js:375
wn @ kbn-ui-shared-deps.js:375
t.unstable_runWithPriority @ kbn-ui-shared-deps.js:383
Hr @ kbn-ui-shared-deps.js:375
se @ kbn-ui-shared-deps.js:375
On @ kbn-ui-shared-deps.js:375
Show 172 more frames
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Embedding Embedding content via iFrame Team:AppServices labels Jan 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@bhavyarm
Copy link
Contributor Author

This is a regression from 7.10.1. Thanks!

@bhavyarm bhavyarm changed the title If you click edit on shared iframe and then click cancel - top nav bar disappears from the frame If you click edit on shared iframe and then click cancel - top nav bar, time filter and query bar disappears from the frame Jan 21, 2021
@ppisljar ppisljar added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort triaged Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Mar 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ppisljar ppisljar mentioned this issue Mar 1, 2021
Closed
@Dosant Dosant mentioned this issue Mar 2, 2021
Closed
@Dosant
Copy link
Contributor

Dosant commented Mar 2, 2021

I am putting the blocked label because it seems it deserves a broader discussion and a somewhat generic approach as part of #93200 and also it isn't critical.

@ThomThomson ThomThomson added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Feb 6, 2023
@ThomThomson
Copy link
Contributor

Re-categorizing this bug to low impact, because it is only relevant from an iframe standpoint, and most users of the iframe functionality don't provide the ability to edit the dashboards.

@ThomThomson
Copy link
Contributor

Closing this for the time being. It will be tracked in our Icebox for Iframe / Embedding issues and will be re-opened if our priorities change.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
@ThomThomson ThomThomson mentioned this issue Apr 10, 2023
Open
@ThomThomson ThomThomson mentioned this issue Oct 5, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked bug Fixes for quality problems that affect the customer experience Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bhavyarm @Dosant @ppisljar @ThomThomson @elasticmachine