Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Fit to data on heatmap not working #92288

Closed
nickofthyme opened this issue Feb 22, 2021 · 3 comments · Fixed by #92697
Closed

[Maps] Fit to data on heatmap not working #92288

nickofthyme opened this issue Feb 22, 2021 · 3 comments · Fixed by #92697
Assignees
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation regression v7.12.0 v8.0.0

Comments

@nickofthyme
Copy link
Contributor

Kibana version:
7.12

Elasticsearch version:
7.12

Browser version:
Chrome Version 88.0.4324.150 (Official Build) (x86_64)

Original install method (e.g. download page, yum, from source, etc.):
build candidate tar.gz

Describe the bug:
Using a heatmap layer in maps, clicking fit data does not work

Steps to reproduce:

  1. Download sample flight data
  2. Add filter for DestCountry : "IT"
  3. Zoom out
  4. Click Fit to data on layer options dropdown
  5. Notice nothing happens

Expected behavior:
Zoom is set by data

Screenshots (if relevant):

Screen.Recording.2021-02-22.at.03.29.33.PM.mp4

Errors in browser console (if relevant):
N/A

Any additional context:
Fit to data works fine on other layers in same map, see screenshot

@nickofthyme nickofthyme added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Feb 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck
Copy link
Contributor

thx for logging, I can reproduce on master.

@nreese
Copy link
Contributor

nreese commented Feb 23, 2021

I can fix. Its a regression caused by #90666. That PR changed HeatmapLayer from extending VectorLayer to just extending AbstractLayer. Looks like getBounds needs to be implemented for HeatmapLayer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation regression v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants