Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY SOLUTIONS][Case Everywhere] Move All Case page #92423

Closed
7 tasks
Tracked by #90905
XavierM opened this issue Feb 23, 2021 · 6 comments
Closed
7 tasks
Tracked by #90905

[SECURITY SOLUTIONS][Case Everywhere] Move All Case page #92423

XavierM opened this issue Feb 23, 2021 · 6 comments
Assignees
Labels
Feature:Cases Cases feature Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v7.13.0

Comments

@XavierM
Copy link
Contributor

XavierM commented Feb 23, 2021

We need to move all the components of the all cases page inside of Case plugins and shared them through our case plugin. We are thinking to extract components one by one to allow different design if needed by solution who wants to integrate case.

AC:

  • Move KPI components
    image
  • Search bar + Filter for cases tables
    image
  • Cases Table
    image
  • Make sure the bundle size of the security solution is not expanding, please make sure to check that in your related PR
  • Move also unit test related to components

###To discuss with engineer: ###
I do not think that we need to create specific component for Edit external connection and/or Create Case because these two component are all about re-routing to a specific page

TC:

  • All case page still working as expected
  • make sure all the appropriate cypress test are still working as expected
@XavierM XavierM added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.13.0 labels Feb 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@cnasikas
Copy link
Member

cnasikas commented Feb 23, 2021

This will also allows us to remove modal logic inside the all cases page. The modal should be built by smaller components and apply its logic when needed.

@stephmilovic stephmilovic added the Feature:Cases Cases feature label Mar 9, 2021
@stephmilovic
Copy link
Contributor

stephmilovic commented Mar 9, 2021

I do not think that we need to create specific component for Edit external connection and/or Create Case because these two component are all about re-routing to a specific page

Are they though? There is specific details on both of these pages, which has changed just about every release. We should make these components so everyone consuming the UI has the updates

@michaelolo24
Copy link
Contributor

The component has been migrated to the cases plugin on our current feature branch: https://github.com/elastic/kibana/tree/cases_rac_ui

We need to move all the components of the all cases page inside of Case plugins and shared them through our case plugin. We are thinking to extract components one by one to allow different design if needed by solution who wants to integrate case.

AC:

  • Move KPI components
    image
  • Search bar + Filter for cases tables
    image
  • Cases Table
    image
  • Make sure the bundle size of the security solution is not expanding, please make sure to check that in your related PR
  • Move also unit test related to components

###To discuss with engineer: ###
I do not think that we need to create specific component for Edit external connection and/or Create Case because these two component are all about re-routing to a specific page

TC:

  • All case page still working as expected
  • make sure all the appropriate cypress test are still working as expected

@michaelolo24
Copy link
Contributor

Closing as these changes were merged in as part of the larger cases-ui effort here:
#97646 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Cases Cases feature Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v7.13.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants