[SECURITY SOLUTIONS] [Case everywhere] Remaining cases removal work

[stephmilovic]

Remaining cases removal work

Remaining moves

• Move Insert Timeline into Cases (See about making renderInvestigateInTimelineActionComponent generic/reusable) [SECURITY SOLUTIONS] [Case everywhere] Move Insert Timeline functionality to Cases #94697 PR: [Security Solution][Cases] Re-enable timeline functionality #96496

Bugs we made

• Wrap all calls to casesUi inuseMemo (follow ConnectorAddFlyout/triggersActionsUi implementations) maybe not, follow this: https://elastic.slack.com/archives/CGK2KMWES/p1618856978042900?thread_ts=1618846558.042700&cid=CGK2KMWES uhh maybe not: After reviewing the casesUi calls we have in security_solution @chandlerprall advised that we keep these calls inline and move them to useMemo "only if it's demonstrated to be a performance issue without. useMemo/useCallback usages includes some extra CPU&memory overhead and shouldn't be employed unless you can show the performance gain is worth the developer experience cost + that perf overhead". He also says "the useMemo way doesn't return a component, it directly returns the result of triggersActionsUi.getAddConnectorFlyout and injects that result"
• Re-add tests for user_action_markdown.test.tsx Steph WIP 4/21
• Handle spyRoute (pass as a prop or allow component to have children??) in case_view PR: [Security Solution][Cases] Fix cases breadcrumbs #97040
• The title of the case is not being shown on the path in case details PR: [Security Solution][Cases] Fix cases breadcrumbs #97040

Bugs we moved over

• Sort by alerts or comments does not work [Security Solution] [Cases] All cases table Alert/Comments column sorting does not work #94948 PR: [Security Solution] [Cases] Small UI bugfixes #96511

Refactors/Cleanup

• refactor message storage to use storage from plugin.ts PR: [Security Solution][Cases] Update messages storage #97514
• Systemize navigation props across all cases components to be common/easy to use schema PR: [Security Solution][Cases] - Update navigation props #96493
• Confirm proper plugin.tsx, tsconfig.json, and linking setup with Kibana PR: [Security Solution] Tsconfig for cases #96249
• Confirm backOptions changes in taking onClick handler in place of pageId Confirmed in [Security Solution][Cases] - Update navigation props #96493**
• Confirm all getCasesColumn calls take in appropriate args object in place of previous args list
• Move the isModal property out of AllCases and break that logic out into its own component PR: [Security Solution] [Cases] All Cases Refactor & getAllCasesSelectorModal introduced #97149
  @cnasikas says:

  I see what you mean. I talk about it with @XavierM and we should break the AllCases components into smaller components and remove the isModal logic. This way we can move the onTableRowClick and alertData logic inside a new modal called, for example, AttachToCaseModal which can be exported through the CasesUiClient.

  Example:

  // AllCases component
  interface Props {
    configureCasesHref: string;
    createCaseHref: string;
    disabledStatuses?: CaseStatuses[];
    getCaseDetailsHref: (caseDetails: CaseDetailsHrefSchema) => string;
    onCaseDetailsNavClick: (caseDetails: CaseDetailsHrefSchema) => void;
    onConfigureCasesNavClick?: (ev: React.MouseEvent) => void;
    onCreateCaseNavClick?: (ev: React.MouseEvent) => void;
    userCanCrud: boolean;
  }
  
  <>
    <AllCasesHeader>
    <AllCasesFilters>
    <AllCasesTable>
  </>
  
  // AttachToCase modal
  interface Props {
     onAttachment: () => void;
  }
  
  <>
    <AllCasesFilters>
    <AllCasesTable>
  </>
  

  I think is a good opportunity to do it in this PR. It will be much cleaner. The AllCases is too compact, does a lot of things without reason.

[elasticmachine]

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

[asnehalb]

Moved non-critical items to https://github.com/elastic/security-team/issues/1091

[asnehalb]

closing as all items here are completed