Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecation] Collect deprecated configs usage #97791

Closed
Bamieh opened this issue Apr 21, 2021 · 2 comments · Fixed by #99887
Closed

[Deprecation] Collect deprecated configs usage #97791

Bamieh opened this issue Apr 21, 2021 · 2 comments · Fixed by #99887
Assignees
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@Bamieh
Copy link
Member

Bamieh commented Apr 21, 2021

We need a way to collect the used deprecated configs in kibana. This is more challenging that I intially thought it would be since

Things to consider:

  • We have no direct way of knowing these configs via config.deprecations since we allow plugins to freely mutate the whole config object. Potential solutions:
    • Use a diff of the previous object and the new object
    • Add an API in @kbn/config to allow the deprecationsHook to specify which keys change
      • Feels like the most practical solution at this time
    • Ideal solution would be for ConfigDeprecationFunction to return just the keys that changed rather than expose an entire mutable object
@Bamieh Bamieh added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry Team:KibanaTelemetry labels Apr 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants