From 5b896765465044a0488ff8e9a3bbc2bbdabbe548 Mon Sep 17 00:00:00 2001
From: Christiane Heiligers <christiane.heiligers@elastic.co>
Date: Wed, 23 Feb 2022 12:13:39 -0700
Subject: [PATCH 1/2] Updates publicBaseUrl warning copy

---
 .../public/core_app/errors/public_base_url.test.tsx    |  2 +-
 src/core/public/core_app/errors/public_base_url.tsx    | 10 +++++-----
 x-pack/plugins/translations/translations/ja-JP.json    |  3 ---
 x-pack/plugins/translations/translations/zh-CN.json    |  3 ---
 4 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/src/core/public/core_app/errors/public_base_url.test.tsx b/src/core/public/core_app/errors/public_base_url.test.tsx
index d1fb5a5093f150..805eb57aa51e0f 100644
--- a/src/core/public/core_app/errors/public_base_url.test.tsx
+++ b/src/core/public/core_app/errors/public_base_url.test.tsx
@@ -85,7 +85,7 @@ describe('publicBaseUrl warning', () => {
       });
 
       expect(notifications.toasts.addWarning).toHaveBeenCalledWith({
-        title: 'Configuration missing',
+        title: 'Configuration recommended',
         text: expect.any(Function),
       });
     });
diff --git a/src/core/public/core_app/errors/public_base_url.tsx b/src/core/public/core_app/errors/public_base_url.tsx
index 3a4cce58bb1c41..5bfe423d007c6e 100644
--- a/src/core/public/core_app/errors/public_base_url.tsx
+++ b/src/core/public/core_app/errors/public_base_url.tsx
@@ -44,15 +44,15 @@ export const setupPublicBaseUrlConfigWarning = ({
   }
 
   const toast = notifications.toasts.addWarning({
-    title: i18n.translate('core.ui.publicBaseUrlWarning.configMissingTitle', {
-      defaultMessage: 'Configuration missing',
+    title: i18n.translate('core.ui.publicBaseUrlWarning.configRecommendedTitle', {
+      defaultMessage: 'Configuration recommended',
     }),
     text: mountReactNode(
       <>
         <p>
           <FormattedMessage
-            id="core.ui.publicBaseUrlWarning.configMissingDescription"
-            defaultMessage="{configKey} is missing and should be configured when running in a production environment. Some features may not behave correctly."
+            id="core.ui.publicBaseUrlWarning.configRecommendedDescription"
+            defaultMessage="In a production environment, it is recommended that you configure {configKey}."
             values={{
               configKey: <code>server.publicBaseUrl</code>,
             }}
@@ -60,7 +60,7 @@ export const setupPublicBaseUrlConfigWarning = ({
           <a href={`${docLinks.links.settings}#server-publicBaseUrl`} target="_blank">
             <FormattedMessage
               id="core.ui.publicBaseUrlWarning.seeDocumentationLinkLabel"
-              defaultMessage="See the documentation."
+              defaultMessage="Refer to the documentation."
             />
           </a>
         </p>
diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
index 8bd17596508973..45afec2f827f65 100644
--- a/x-pack/plugins/translations/translations/ja-JP.json
+++ b/x-pack/plugins/translations/translations/ja-JP.json
@@ -1636,10 +1636,7 @@
     "core.ui.primaryNav.screenReaderLabel": "プライマリ",
     "core.ui.primaryNav.toggleNavAriaLabel": "プライマリナビゲーションを切り替える",
     "core.ui.primaryNavSection.screenReaderLabel": "プライマリナビゲーションリンク、{category}",
-    "core.ui.publicBaseUrlWarning.configMissingDescription": "{configKey}が見つかりません。本番環境を実行するときに構成してください。一部の機能が正常に動作しない場合があります。",
-    "core.ui.publicBaseUrlWarning.configMissingTitle": "構成がありません",
     "core.ui.publicBaseUrlWarning.muteWarningButtonLabel": "ミュート警告",
-    "core.ui.publicBaseUrlWarning.seeDocumentationLinkLabel": "ドキュメントを参照してください。",
     "core.ui.recentLinks.linkItem.screenReaderLabel": "{recentlyAccessedItemLinklabel}、タイプ：{pageType}",
     "core.ui.recentlyViewed": "最近閲覧",
     "core.ui.recentlyViewedAriaLabel": "最近閲覧したリンク",
diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
index 197c982b01fd91..5ced6d271aa629 100644
--- a/x-pack/plugins/translations/translations/zh-CN.json
+++ b/x-pack/plugins/translations/translations/zh-CN.json
@@ -1643,10 +1643,7 @@
     "core.ui.primaryNav.screenReaderLabel": "主分片",
     "core.ui.primaryNav.toggleNavAriaLabel": "切换主导航",
     "core.ui.primaryNavSection.screenReaderLabel": "主导航链接, {category}",
-    "core.ui.publicBaseUrlWarning.configMissingDescription": "{configKey} 缺失，在生产环境中运行时应配置。某些功能可能运行不正常。",
-    "core.ui.publicBaseUrlWarning.configMissingTitle": "配置缺失",
     "core.ui.publicBaseUrlWarning.muteWarningButtonLabel": "静音警告",
-    "core.ui.publicBaseUrlWarning.seeDocumentationLinkLabel": "请参阅文档。",
     "core.ui.recentLinks.linkItem.screenReaderLabel": "{recentlyAccessedItemLinklabel}，类型：{pageType}",
     "core.ui.recentlyViewed": "最近查看",
     "core.ui.recentlyViewedAriaLabel": "最近查看的链接",

From 85a8860088c4c209b149b4024f730ca20c895c3f Mon Sep 17 00:00:00 2001
From: Christiane Heiligers <christiane.heiligers@elastic.co>
Date: Wed, 23 Feb 2022 17:09:07 -0700
Subject: [PATCH 2/2] Improves documentation link label

---
 src/core/public/core_app/errors/public_base_url.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/core/public/core_app/errors/public_base_url.tsx b/src/core/public/core_app/errors/public_base_url.tsx
index 5bfe423d007c6e..59c9577470d266 100644
--- a/src/core/public/core_app/errors/public_base_url.tsx
+++ b/src/core/public/core_app/errors/public_base_url.tsx
@@ -59,8 +59,8 @@ export const setupPublicBaseUrlConfigWarning = ({
           />{' '}
           <a href={`${docLinks.links.settings}#server-publicBaseUrl`} target="_blank">
             <FormattedMessage
-              id="core.ui.publicBaseUrlWarning.seeDocumentationLinkLabel"
-              defaultMessage="Refer to the documentation."
+              id="core.ui.publicBaseUrlWarning.learnMoreLinkLabel"
+              defaultMessage="Learn more."
             />
           </a>
         </p>