From 007ecd25f06ffc76698044feb72873be8680ff50 Mon Sep 17 00:00:00 2001
From: Peter Pisljar <peter.pisljar@gmail.com>
Date: Fri, 23 Nov 2018 11:41:50 +0100
Subject: [PATCH] show drop partial buckets option (#25520)

---
 .../agg_types/controls/drop_partials.html     |  4 +-
 .../apps/visualize/_vertical_bar_chart.js     | 46 +++++++++++++++++++
 .../functional/page_objects/visualize_page.js |  4 ++
 3 files changed, 52 insertions(+), 2 deletions(-)

diff --git a/src/ui/public/agg_types/controls/drop_partials.html b/src/ui/public/agg_types/controls/drop_partials.html
index 3b3713db22f871..776916e4817dd0 100644
--- a/src/ui/public/agg_types/controls/drop_partials.html
+++ b/src/ui/public/agg_types/controls/drop_partials.html
@@ -1,6 +1,6 @@
-<div class="checkbox" ng-if="agg.params.field.name === agg.vis.indexPattern.timeFieldName">
+<div class="checkbox" ng-if="agg.params.field.name === agg.getIndexPattern().timeFieldName">
   <label>
-    <input ng-model="agg.params.drop_partials" type="checkbox">
+    <input ng-model="agg.params.drop_partials" type="checkbox" data-test-subj="dropPartialBucketsCheckbox">
     Drop partial buckets
     &nbsp;
     <icon-tip
diff --git a/test/functional/apps/visualize/_vertical_bar_chart.js b/test/functional/apps/visualize/_vertical_bar_chart.js
index 546897c74b3f3d..f15ab1cc7cd533 100644
--- a/test/functional/apps/visualize/_vertical_bar_chart.js
+++ b/test/functional/apps/visualize/_vertical_bar_chart.js
@@ -111,10 +111,56 @@ export default function ({ getService, getPageObjects }) {
 
       await PageObjects.visualize.openInspector();
       const data = await PageObjects.visualize.getInspectorTableData();
+      await PageObjects.visualize.closeInspector();
       log.debug(data);
       expect(data).to.eql(expectedChartData);
     });
 
+    it('should have `drop partial buckets` option', async () => {
+      const fromTime = '2015-09-20 06:31:44.000';
+      const toTime = '2015-09-22 18:31:44.000';
+
+      await PageObjects.header.setAbsoluteRange(fromTime, toTime);
+
+      let expectedChartValues = [
+        82, 218, 341, 440, 480, 517, 522, 446, 403, 321, 258, 172, 95, 55, 38, 24, 3, 4,
+        11, 14, 17, 38, 49, 115, 152, 216, 315, 402, 446, 513, 520, 474, 421, 307, 230,
+        170, 99, 48, 30, 15, 10, 2, 8, 7, 17, 34, 37, 104, 153, 241, 313, 404, 492, 512,
+        503, 473, 379, 293, 277, 156, 56
+      ];
+
+      // Most recent failure on Jenkins usually indicates the bar chart is still being drawn?
+      // return arguments[0].getAttribute(arguments[1]);","args":[{"ELEMENT":"592"},"fill"]}] arguments[0].getAttribute is not a function
+      // try sleeping a bit before getting that data
+      await retry.try(async () => {
+        const data = await PageObjects.visualize.getBarChartData();
+        log.debug('data=' + data);
+        log.debug('data.length=' + data.length);
+        expect(data).to.eql(expectedChartValues);
+      });
+
+      await PageObjects.visualize.toggleOpenEditor(2);
+      await PageObjects.visualize.clickDropPartialBuckets();
+      await PageObjects.visualize.clickGo();
+
+      expectedChartValues = [
+        218, 341, 440, 480, 517, 522, 446, 403, 321, 258, 172, 95, 55, 38, 24, 3, 4,
+        11, 14, 17, 38, 49, 115, 152, 216, 315, 402, 446, 513, 520, 474, 421, 307, 230,
+        170, 99, 48, 30, 15, 10, 2, 8, 7, 17, 34, 37, 104, 153, 241, 313, 404, 492, 512,
+        503, 473, 379, 293, 277, 156
+      ];
+
+      // Most recent failure on Jenkins usually indicates the bar chart is still being drawn?
+      // return arguments[0].getAttribute(arguments[1]);","args":[{"ELEMENT":"592"},"fill"]}] arguments[0].getAttribute is not a function
+      // try sleeping a bit before getting that data
+      await retry.try(async () => {
+        const data = await PageObjects.visualize.getBarChartData();
+        log.debug('data=' + data);
+        log.debug('data.length=' + data.length);
+        expect(data).to.eql(expectedChartValues);
+      });
+    });
+
     describe.skip('switch between Y axis scale types', () => {
       before(initBarChart);
       const axisId = 'ValueAxis-1';
diff --git a/test/functional/page_objects/visualize_page.js b/test/functional/page_objects/visualize_page.js
index 5a89a2115ed5e1..24378c91bc6396 100644
--- a/test/functional/page_objects/visualize_page.js
+++ b/test/functional/page_objects/visualize_page.js
@@ -216,6 +216,10 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
         defaultFindTimeout * 2);
     }
 
+    async clickDropPartialBuckets() {
+      return await testSubjects.click('dropPartialBucketsCheckbox');
+    }
+
     async setMarkdownTxt(markdownTxt) {
       const input = await testSubjects.find('markdownTextarea');
       await input.clearValue();