Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "X kicked X" terminology when removing people from a room #4865

Closed
gaelledel opened this issue Jan 5, 2022 · 14 comments · Fixed by #4911
Closed

Remove "X kicked X" terminology when removing people from a room #4865

gaelledel opened this issue Jan 5, 2022 · 14 comments · Fixed by #4911
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF moment: High Impact, Low Effort

Comments

@gaelledel
Copy link

gaelledel commented Jan 5, 2022

This issue is: Ready to Build

What would you like to do?

To remove the wording "X kicked X" when someone is removed from a room and replace with "X removed X"

Why would you like to do it?

Because it is more acceptable terminology


EDIT bmarty
Ok, confirmed internally:

  • replace all instance of "kick" and their variations to "remove" and their variations in the English wording. Translation will updated later following the regular Weblate process. No need to create new strings.
  • add the slash command /remove but keep the existing /kick for now. They will have the same effect.
@gaelledel gaelledel added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jan 5, 2022
@gaelledel gaelledel changed the title Remove "X kicked X" terminology when removing people from a room #5346 Remove "X kicked X" terminology when removing people from a room Jan 5, 2022
@bmarty
Copy link
Member

bmarty commented Jan 5, 2022

"removed" is a bit strange to me, maybe "excluded"?
Anyway we will need a confirmation from the product team (@daniellekirkwood ) to do this change, also it will have to be done on all the Element apps.

@daniellekirkwood
Copy link
Contributor

I agree. Is this message specifically for the event in the timeline? Could you provide a screenshot, @gaelledel?

Also note that "kicked" is the terminology we use across the product for this action. It would be strange to kick a user from a room and then not see that confirmation in the timeline...

Benoit, "Excluded" has different meaning in English - for example, when children are excluded from school, they are not allowed back. It's also a more emotive term - to feel excluded. When a user is Kicked from a Room, they could be invited back in?

@gaelledel
Copy link
Author

gaelledel commented Jan 6, 2022

Using the term Removed is absolutely fine and I had a discussion with Matthew about it a long time ago so please let's just go with it. No point debating on this subject any further as it was discussed again and again... This is now done on the web just waiting for this to be done on mobile for a synced update cross plat.
matrix-org/matrix-react-sdk#7469 (review)

Linked to element-hq/element-web#9547

@gaelledel
Copy link
Author

gaelledel commented Jan 6, 2022

Please note that the term kick will obviously have to be replaced with "remove" at several other areas. Please check @t3chguy PR here for more info matrix-org/matrix-react-sdk#7469
We can therefore use "Remove from chat" in both rooms and DMs

@gaelledel gaelledel added the Z-WTF WTF moment: High Impact, Low Effort label Jan 6, 2022
@bmarty
Copy link
Member

bmarty commented Jan 6, 2022

A kicked user can freely join again a public room. A banned user cannot.

@daniellekirkwood daniellekirkwood removed their assignment Jan 6, 2022
@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Jan 10, 2022

There are other strings that don't have a clear replacement path (raised by @fedrunov)

"kicking user will remove them from this room.\n\nTo prevent them from joining again, you should ban them instead."
"Invites, kicks, and bans are unaffected."

from to
"kicking user will remove them from this room. To prevent them from joining again, you should ban them instead." The user will be removed from this room. To prevent them from joining again, you should ban them instead.
Invites, kicks, and bans are unaffected. Invites, removes, and bans are unaffected

@gaelledel Can you please confirm the replacement text is ok?

@bmarty
Copy link
Member

bmarty commented Jan 14, 2022

Will be in Element 1.3.16

@t3chguy
Copy link
Member

t3chguy commented Jan 14, 2022

I was under the impression this needed a synchronised release between all the platforms.

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Jan 14, 2022

I don't think we have to do it all at the same time as the Kick action will still work everywhere. Some content changes and an additional "Remove" action should cause too much of an issue

Good reminder for me to check on the status across platforms though, thanks

@t3chguy
Copy link
Member

t3chguy commented Jan 14, 2022

Well its been ready on Web pending a synced release so that users aren't confused seeing Kick on one platform and Remove on another

@bmarty
Copy link
Member

bmarty commented Jan 14, 2022

Note that Element 1.3.16 release candidate is scheduled to be done January 25th and the next Monday on Prod

@daniellekirkwood
Copy link
Contributor

Well its been ready on Web pending a synced release so that users aren't confused seeing Kick on one platform and Remove on another

Can you send me the issue, let's go ahead and push it thru on web too

@t3chguy
Copy link
Member

t3chguy commented Jan 14, 2022

@SPiRiT369
Copy link
Contributor

I like this change and never understood why the brutal "kick" word was chosen back in the IRC days. Looking forward for replacing "ban" with "block"! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF moment: High Impact, Low Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants