Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS notifications are broken with Synapse 1.33.0 #4309

Closed
manuroe opened this issue May 6, 2021 · 2 comments · Fixed by matrix-org/matrix-ios-sdk#1100
Closed

iOS notifications are broken with Synapse 1.33.0 #4309

manuroe opened this issue May 6, 2021 · 2 comments · Fixed by matrix-org/matrix-ios-sdk#1100

Comments

@manuroe
Copy link
Member

manuroe commented May 6, 2021

Because of matrix-org/synapse#9919, the swift code and its strong type check crashes.

@manuroe
Copy link
Member Author

manuroe commented May 11, 2021

We can probably run our integration tests against matrix-org/synapse#9919.

@manuroe
Copy link
Member Author

manuroe commented May 12, 2021

This is probably the right time to start to:

  • enable NS_ASSUME_NONNULL_BEGIN in our MXJSONModel classes and use nullable according to matrix.org spec
  • split MXJSONModels.h into dedicated classes

We can start this with all JSON models related to the /sync response. It may worth to package all models into a dedicated subfolder.
The runtime crashes due to this synapse change should then be visible as build errors in our swift code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants