Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to nag bar for incoming verification #11223

Closed
9 tasks done
dbkr opened this issue Oct 24, 2019 · 0 comments
Closed
9 tasks done

Change to nag bar for incoming verification #11223

dbkr opened this issue Oct 24, 2019 · 0 comments
Assignees

Comments

@dbkr
Copy link
Member

dbkr commented Oct 24, 2019

Show a nag bar at the top of the screen as per designs on an incoming verification request rather than popping up a dialog straight away.

  • At this stage we can still show the same dialog when you click on the bar
  • create a new toast component, flexible enough to show any kind of notification
  • add verification request toasts for crypto.verification.start/Room.timeline verification events on client, open sas dialog when accepting

Remaining things

  • when accepting or cancelling request through timeline tile, make toast disappear
  • accepted or declined requests still show on load
  • undefined name in toast
  • switch to DM with accepting request on toast
  • feature flag the toasts
  • make it work for legacy to_device verification requests as well
  • merge FormButton styles with buttons used in key verification tile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants