Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink release process so we can support native node modules #11227

Closed
dbkr opened this issue Oct 24, 2019 · 4 comments
Closed

Rethink release process so we can support native node modules #11227

dbkr opened this issue Oct 24, 2019 · 4 comments
Assignees
@dbkr
Labels
A-E2EE-Cross-Signing

Comments

@dbkr
Copy link
Member

dbkr commented Oct 24, 2019

Blocks: #11125
Blocks: #10369
@dbkr dbkr mentioned this issue Oct 24, 2019
Open
@turt2live
Copy link
Member

Related: #8299

@jryans
Copy link
Collaborator

jryans commented Nov 5, 2019

As an interim step to avoid long-lived PRs waiting for this process, we're going to attempt the following:

  • Test for the native node module(s) needed with runtime checks
  • Do not add the native node module as an app dependency (instead record what should be added in a doc)

@turt2live
Copy link
Member

The label "new-build-process" fixes this.

@jryans jryans added story:39 and removed story:5 labels Jan 21, 2020
@dbkr dbkr self-assigned this Feb 12, 2020
@jryans jryans added phase:3 and removed story:39 labels Feb 12, 2020
This was referenced Feb 21, 2020
Closed
Closed
Closed
@dbkr
Copy link
Member Author

dbkr commented Feb 21, 2020

Split out into the above.

@dbkr dbkr closed this as completed Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
A-E2EE-Cross-Signing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @dbkr @turt2live @lampholder