Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing enter after a URL #17301

Closed
thany opened this issue May 14, 2021 · 6 comments
Closed

Pressing enter after a URL #17301

thany opened this issue May 14, 2021 · 6 comments
Labels
A-Composer T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@thany
Copy link

thany commented May 14, 2021

Description

Pressing enter (might be shift+enter) after a URL duplicates the last character of the URL onto the next line.

Steps to reproduce

  • In a conversation in the message box underneath, paste a URL. Any URL will do, as far as I can tell.
  • Press Shift+Enter to make a newline, rather than send the message. If you've set Ctrl+Enter to send, regular Enter will do as well, although I'm not 100% certain.
  • Observe the last character of the pasted url being copied and carried over the the next line.

This doesn't happen always. So please try a few times before saying "cannot reproduce" and calling it a day 🙏

Logs being sent: no (I don't really think this is the type of bug that requires them, but lemme know if you need them).

Version information

  • Platform: desktop
  • OS: Windows 10 20H2
  • Version: 1.7.27
@thany thany added the T-Defect label May 14, 2021
@t3chguy
Copy link
Member

t3chguy commented May 14, 2021

This looks like #17215 ?

@thany
Copy link
Author

thany commented May 14, 2021

Possibly, but I've only ever had this problem with pasted urls...

@SimonBrandner SimonBrandner added A-Composer X-Needs-Info This issue is blocked awaiting information from the reporter labels May 15, 2021
@yannicka
Copy link

yannicka commented May 31, 2021

For me it's the same problem as #17215 (only with the "Use Ctrl + Enter to send a message" parameter enabled).

Whether I am typing a URL or text, when I press Shift+Enter, it duplicates the last character of the previous line:

Peek.31-05-2021.23-01.mp4

If I press Enter only, I don't have this problem (the new line is put as expected).

  • Element Desktop 1.7.29.

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Jun 1, 2021

@thany, could you please confirm this is a dupe of #17215?

@thany
Copy link
Author

thany commented Jun 4, 2021

Yes, I checked, it's a dupe.

Well, I guess that confirms some extra priority if two issues exist for the same bug 😘

@SimonBrandner
Copy link
Contributor

Closing then, there is already a PR to fix this, btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

4 participants