Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disambiguation in IRC layout only partially fixed #17930

Closed
emorrp1 opened this issue Jul 10, 2021 · 2 comments
Closed

disambiguation in IRC layout only partially fixed #17930

emorrp1 opened this issue Jul 10, 2021 · 2 comments
Assignees
@SimonBrandner
Labels
A-IRC-Layout A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@emorrp1
Copy link

emorrp1 commented Jul 10, 2021

image

Description

#17648 was mostly fixed by matrix-org/matrix-react-sdk#6193 but when the ambiguous user is yourself, the username is now blank until you hover over it, then the mxid overlaps text again.

Steps to reproduce

  • Switch to IRC layout
  • Create similar displaynames and hover over a message.

Expect to see a reasonable representation of the user

Version information

For the desktop app:

  • OS: Debian 10
  • Version: 1.7.32
@SimonBrandner
Copy link
Contributor

This is one of the IRC layout regressions caused by matrix-org/matrix-react-sdk#5880 and by one more PR whose name I don't remember.

Will try to figure out what to do next with this

@SimonBrandner SimonBrandner mentioned this issue Jul 10, 2021
Closed
@SimonBrandner SimonBrandner self-assigned this Jul 13, 2021
@SimonBrandner SimonBrandner mentioned this issue Jul 13, 2021
Closed
@novocaine novocaine added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Nov 19, 2021
@SimonBrandner
Copy link
Contributor

Fixed by matrix-org/matrix-react-sdk#7652 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
A-IRC-Layout A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix IRC layout disambiguation SimonBrandner/matrix-react-sdk
3 participants
@novocaine @emorrp1 @SimonBrandner