Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability for sender to respond to keyshare requests from new verified recipient devices #18666

Closed
ara4n opened this issue Aug 20, 2021 · 2 comments
Closed

Ability for sender to respond to keyshare requests from new verified recipient devices #18666

ara4n opened this issue Aug 20, 2021 · 2 comments
Labels
A-E2EE A-Session-Mgmt Session / device names, management UI, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Z-UISI Unable to decrypt errors

Comments

@ara4n
Copy link
Member

ara4n commented Aug 20, 2021 •
edited by novocaine
Loading

Currently, if a recipient sees a UISI they send a keyshare request to all their other devices, and the specific device which sent the message in the first place. (We don't send the request to the sender's other devices, as they don't necessarily know independently of the server whether the recipient was in the room at the point that the message was sent).

However, the specific device which receives the request currently will not service the request unless the requesting device is the one they sent the key to in the first place. So, if there's a netsplit, and a new device is added on the far side of the netsplit, that new device will request but never receive keys from the sending device. If the newly added device has been verified, then the sender should be happy to share keys with it.
@MadLittleMods MadLittleMods added Z-UISI Unable to decrypt errors A-Session-Mgmt Session / device names, management UI, etc. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect labels Aug 24, 2021
@MadLittleMods MadLittleMods mentioned this issue Aug 24, 2021
Open
@novocaine novocaine added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 25, 2021
@novocaine
Copy link
Contributor

Downloading to O-Low as I believe netsplits are rare

@turt2live
Copy link
Member

Duplicate of element-hq/element-meta#1888

@turt2live turt2live closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE A-Session-Mgmt Session / device names, management UI, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect Z-UISI Unable to decrypt errors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@novocaine @MadLittleMods @turt2live @ara4n