Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ping/highlight colour notification #18802

Closed
1 of 8 tasks
kittykat opened this issue Aug 26, 2021 · 3 comments
Closed
1 of 8 tasks

Improve ping/highlight colour notification #18802

kittykat opened this issue Aug 26, 2021 · 3 comments
Assignees
Labels
A11y A-Notifications A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Needs-Design Z-GetYourUpdates

Comments

@kittykat
Copy link
Contributor

kittykat commented Aug 26, 2021

Your use case

What would you like to do?

Change ping/highlight colour.
Screenshot from 2021-08-26 21-31-19

Why would you like to do it?

  • Red is a jarring colour
  • Red is a poor choice for red/* colourblind users

How would you like to achieve it?

Pre-development checks

  • Tagged as T-Enhancement and with correct A-* label
  • Product team confirmed that this feature:
    • …is on the roadmap or
    • …could be added to the roadmap or developed by a community member
  • Final design has been approved by the Element design team and attached to this issue:
  • Acceptance criteria:
    • Default colour of pings is changed to be not as jarring
    • Default colour can be changed by users
@kittykat kittykat added A-Timeline A-Notifications T-Enhancement O-Occasional Affects or can be seen by some users regularly or most users rarely X-Needs-Design A11y labels Aug 26, 2021
@kittykat kittykat added the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label Aug 27, 2021
@kittykat
Copy link
Contributor Author

Major because it could cause missed notifications for people who have colourblindness

@janogarcia
Copy link

@rufuskahler Will be addressed by the new color system in the works as for #23302 (comment) 👍

@daniellekirkwood
Copy link
Contributor

We've completed the colour pass and the Red has shifted tone (and will continue to be iterated on with other tracks of work). All the linked issues are closed so I'm going to close this as complete for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y A-Notifications A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Needs-Design Z-GetYourUpdates
Projects
None yet
Development

No branches or pull requests

4 participants