Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space notification dots are misaligned when space panel overflows #19017

Closed
robintown opened this issue Sep 14, 2021 · 7 comments
Closed

Space notification dots are misaligned when space panel overflows #19017

robintown opened this issue Sep 14, 2021 · 7 comments
Labels
A-Notifications A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect X-Cannot-Reproduce Z-Platform-Specific

Comments

@robintown
Copy link
Member

robintown commented Sep 14, 2021

Steps to reproduce

  1. Have a notification or unread message in a subspace
  2. Shrink the browser window vertically until the space panel overflows

What happened?

The notification dot in the top level space is out of alignment with the notification dot in the subspace:

Screenshot 2021-09-13 at 22-46-01 Element general

What did you expect?

The notification dots should be aligned, as they are when the space panel is not overflowing:

Screenshot 2021-09-13 at 22-45-21 Element general

Operating system

NixOS unstable

Browser information

Firefox 91.0.2

URL for webapp

develop.element.io

Homeserver

townsendandsmith.ml

Have you submitted a rageshake?

No

@robintown robintown added T-Defect S-Tolerable Low/no impact on users A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 14, 2021
@t3chguy
Copy link
Member

t3chguy commented Sep 14, 2021

I couldn't get the right things to happen for this to show up, are you still able to reproduce this using matrix-org/matrix-react-sdk#6800 ?

@robintown
Copy link
Member Author

Yes, it still reproduces for me with that PR

@t3chguy
Copy link
Member

t3chguy commented Sep 29, 2021

I cannot reproduce this issue

image

@robintown
Copy link
Member Author

robintown commented Sep 29, 2021

I think it's probably specific to Firefox (still easily reproduceable for me)

@t3chguy
Copy link
Member

t3chguy commented Sep 29, 2021

I was using Firefox 92.0.1 on macOS

@robintown
Copy link
Member Author

robintown commented Sep 29, 2021

🤔 it might have something to do with how Firefox interacts with GTK scroll bars on Linux then?

@robintown
Copy link
Member Author

Fixed by matrix-org/matrix-react-sdk#6977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect X-Cannot-Reproduce Z-Platform-Specific
Projects
None yet
Development

No branches or pull requests

3 participants