Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted message "reason": requires restart to appear #20382

Closed
Winterhuman opened this issue Dec 31, 2021 · 5 comments
Closed

Deleted message "reason": requires restart to appear #20382

Winterhuman opened this issue Dec 31, 2021 · 5 comments
Labels
A-E2EE A-Message-Editing A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Investigation

Comments

@Winterhuman
Copy link

Winterhuman commented Dec 31, 2021 •
edited
Loading

Steps to reproduce

  1. Send a message to someone
  2. Delete the message, with a reason
  3. View the deleted message's source and see no reason section
  4. Fully exit and restart Element Desktop
  5. View the deleted message's source again and see the "reason": field appear alongside other fields not present before the restart

Outcome

What did you expect?

"View Source" should show the actual source of the deleted message without requiring a restart of Element, or, should at least update by itself if the message's source takes time to finalize.

What happened instead?

The source of deleted messages' remain minimal until the user restarts Element, waiting for the message to update doesn't work.

Operating system

Arch Linux

Application version

Element version: 1.9.8 Olm version: 3.2.8

How did you install the app?

FlatHub

Homeserver

matrix.org

Will you send logs?

No
@kittykat
Copy link
Contributor

kittykat commented Jan 1, 2022

I can also confirm that it takes a long time to appear on web as well (on develop).

@kittykat kittykat added A-Message-Editing A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 1, 2022
@SimonBrandner
Copy link
Contributor

This seems to be present only in encrypted rooms

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Jan 2, 2022 •
edited
Loading

This is caused by MatrixEvent::makeRedacted() not setting MatrixEvent::clearEvent

@SimonBrandner SimonBrandner self-assigned this Jan 9, 2022
@SimonBrandner SimonBrandner mentioned this issue Jan 9, 2022
Closed
@SimonBrandner SimonBrandner removed their assignment Jan 10, 2022
@SimonBrandner
Copy link
Contributor

There is some confusion regarding how should this work, see https://matrix.to/#/!bEWtlqtDwCLFIAKAcv:matrix.org/$hZdXXwCdxBrqxS5BTwbhMGSvjz62JA4sIG9f6OUVDtM?via=matrix.org&via=tchncs.de&via=chat.weho.st

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Jan 10, 2022 •
edited
Loading

Closing in favour of #20460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE A-Message-Editing A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kittykat @SimonBrandner @Winterhuman