Position of remove button in message edit modal seems wrong

[alunturner]

Steps to reproduce

Where are you starting? What can you see?

• When interacting with an edited message, the position of the Remove button seems a long way from the item it's related to, and is offset vertically from where I'd expect it to be
• Because the appearance of this button is controlled by hovering over the edit item you'd like to remove, the vertical offset means that trying to move your pointer directly to the button can result in the button disappearing
• In order to get your pointer onto the button, you need to move the pointer horizontally "along" the item, before moving up and onto the button
• Image

- Video

Screen.Recording.2023-03-24.at.10.45.18.mov

To reproduce

• Edit a message in the timeline
• Click on the (edited) text that follows the message to open the Message edits modal
• Hover the pointer over the top item (ie the most recent edit)
• Observe the position of the button labelled Remove
• Try to move the pointer to click that Remove button

Outcome

What did you expect?

I expected the Remove button to at least be vertically aligned, and potentially be a bit closer (accepting that I've shown this with a tiny edit, perhaps it's horizontal separation makes sense given an edit could be large).

Operating system

Mac OS

Application version

Nightly

Will you send logs?

No

[luixxiul]

It looks the remove button (and also View Source button in developer mode) is based on the existing MessageActionBar component (you could refer from here), so IMHO this would need a design input for a better UX (by adding a new component for the dialog, for example).

[luixxiul]

For now, enabling highlight of messages on hover by emulating EventTile on the main timeline could improve UX a bit.

peek.mp4

[andybalaam]

I agree that moving the Remove button would be ideal here, but I think that matrix-org/matrix-react-sdk#11674 is probably good enough, and this dialog is rarely-used enough that I don't want to try and spend designers' time on improving it right now, so I'm happy to say this is "fixed" by that PR.