Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New room icons don't show up correctly in pills #26046

Closed
daniellekirkwood opened this issue Aug 24, 2023 · 7 comments · Fixed by matrix-org/matrix-react-sdk#11473
Closed

New room icons don't show up correctly in pills #26046

daniellekirkwood opened this issue Aug 24, 2023 · 7 comments · Fixed by matrix-org/matrix-react-sdk#11473
Assignees
Labels
A-Message-Bubbles A-Pills O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression Z-Compound

Comments

@daniellekirkwood
Copy link
Contributor

Steps to reproduce

  1. Where are you starting? What can you see?
Screenshot 2023-08-24 at 12 20 40
  1. What do you click?
  2. More steps…

Outcome

What did you expect?

What happened instead?

Operating system

MacOS

Application version

Element Nightly version: 2023082401 Olm version: 3.2.14

How did you install the app?

element.io

Homeserver

ems

Will you send logs?

No

@daniellekirkwood
Copy link
Contributor Author

Sorry to just assign this to you @germain-gg but as i know you're the only one working on it, it felt simpler 😂

not sure i've included all the info you need or the right labels - let me know

@andybalaam andybalaam added S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 24, 2023
@andybalaam
Copy link
Contributor

Yeah @germain-gg I would recommend a close look at the Percy screenshots above (all 47 of them). Many look like they might be unintentional changes.

@germain-gg
Copy link
Contributor

I've fixed a couple of issues after going through the percy tests, thank you for that!

However, I can not reproduce the issue listed here? @daniellekirkwood does that still occur to you?
Screenshot 2023-08-25 at 10 40 11

@daniellekirkwood
Copy link
Contributor Author

Yes, only with bubbles on though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Message-Bubbles A-Pills O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression Z-Compound
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants