Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passphrase Field score tooltip colours misleading #26189

Open
t3chguy opened this issue Sep 18, 2023 · 2 comments
Open

Passphrase Field score tooltip colours misleading #26189

t3chguy opened this issue Sep 18, 2023 · 2 comments
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Compound

Comments

@t3chguy
Copy link
Member

t3chguy commented Sep 18, 2023

Steps to reproduce

  1. Start creating account
  2. Enter a medium security password like password123123133112

Outcome

What did you expect?

image

What happened instead?

image

This is too similar to low

Before
image

After
image

Which makes it look like a hard-fail which is a strange juxtaposition next to the green tick saying nice password.

Regressed by matrix-org/matrix-react-sdk#11079

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@Johennes
Copy link
Contributor

@nadonomy can you advise on the best color shades to use here?

@kittykat kittykat added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 4, 2023
@nadonomy
Copy link
Contributor

nadonomy commented Nov 8, 2023 •
edited
Loading

I think we should just switch these to use the semantic palette (https://compound.element.io/?path=/docs/tokens-semantic-colors--docs) - on all of the tooltip elements (icon, bar fill, copy) - success-primary when the user can continue, info-primary when they can't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Compound
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kittykat @Johennes @t3chguy @nadonomy