Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room details: room description #26595

Closed
Tracked by #25883
kerryarchibald opened this issue Nov 16, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12503
Closed
Tracked by #25883

Room details: room description #26595

kerryarchibald opened this issue Nov 16, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12503

Comments

@kerryarchibald
Copy link
Contributor

kerryarchibald commented Nov 16, 2023

https://www.figma.com/file/rTaQE2nIUSLav4Tg3nozq7/Compound-Web-Components?type=design&node-id=1073-6237&mode=design&t=PifxQQLUULHatXkK-4

https://www.figma.com/file/wqgXVb7RVaIybfRsXdWEiL/Element-Web-Room-Header-%26-Details?node-id=1478%3A102982&mode=dev

Screenshot 2023-11-16 at 17 40 07 Screenshot 2023-11-22 at 14 59 54 https://www.figma.com/file/wqgXVb7RVaIybfRsXdWEiL/Element-Web-Room-Header-%26-Details?node-id=454%3A51346&mode=dev

AC:

  • When room has no topic and user has no edit rights, display nothing
  • When room has no topic and user has edit rights, display: 'Add topic' cta that opens room settings dialog
  • Rich text topics are rendered correctly
  • Emoji in topic is rendered correctly
  • Topic is truncated to two lines
  • Clicking the caret expands to show the full topic
  • When the topic is expanded and the user has rights, an edit button is displayed that opens room settings dialog
@kerryarchibald kerryarchibald changed the title [Room description](https://www.figma.com/file/rTaQE2nIUSLav4Tg3nozq7/Compound-Web-Components?type=design&node-id=1073-6237&mode=design&t=PifxQQLUULHatXkK-4) missing Room details: room description Nov 16, 2023
@kerryarchibald kerryarchibald self-assigned this Nov 22, 2023
@dbkr
Copy link
Member

dbkr commented Jan 29, 2024

I'm guessing we would probably want to add a compound component for this (I don't see one) so maybe a day for this. I'm also not seeing what the edit link does? If that needs an edit view we don't have, then more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants